Re: [boost] Formal Review: Boost.Polygon starts today August 24, 2009

Subject: Re: [boost] Formal Review: Boost.Polygon starts today August 24, 2009
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2009-08-29 16:36:36

AMDG

I ran the test with most of the compilers I have available.
I'm getting a lot of compiler warnings from msvc-9.0express, 
msvc-8.0express, and gcc-3.4.4.
gcc-4.2.3, gcc-4.3.0, and gcc-mingw-4.4.1 are fine.

como fails with

"c:\boost\gtl\boost\polygon\detail/iterator_points_to_compact.hpp", line 
21: err
or #135:
          namespace "std" has no member "ptrdiff_t"
    typedef std::ptrdiff_t difference_type;
                 ^

"c:\boost\gtl\boost\polygon\detail/iterator_compact_to_points.hpp", line 
22: err
or #135:
          namespace "std" has no member "ptrdiff_t"
    typedef std::ptrdiff_t difference_type;
                 ^

"c:\boost\gtl\boost\polygon\polygon_45_data.hpp", line 63: error #135:
          namespace "std" has no member "size_t"
    inline std::size_t size() const { return coords_.size(); }
                ^

"c:\boost\gtl\boost\polygon\polygon_data.hpp", line 61: error #135: 
namespace
          "std" has no member "size_t"
    inline std::size_t size() const { return coords_.size(); }
                ^

"c:\boost\gtl\boost\polygon\polygon_90_data.hpp", line 70: error #135:
          namespace "std" has no member "size_t"
    inline std::size_t size() const { return coords_.size(); }
                ^

Error limit reached.
5 errors detected in the compilation of "gtl_boost_unit_test.cpp".
Compilation terminated.

Did you not #include <cstddef>?

sun-5.9 says
"detail/property_merge.hpp", line 286: Warning: output hides 
boost::polygon::merge_scanline<int, int, 
boost::polygon::polygon_90_set_data<int>, std::set<int>>::output.
"detail/property_merge.hpp", line 127:     Where: While instantiating 
"boost::polygon::merge_scanline<int, int, 
boost::polygon::polygon_90_set_data<int>, 
std::set<int>>::processVertex(std::vector<std::pair<boost::polygon::property_merge_interval<int>, 
std::pair<std::set<int>, std::set<int>>>, 
std::allocator<std::pair<boost::polygon::property_merge_interval<int>, 
std::pair<std::set<int>, std::set<int>>>>>&)".
"detail/property_merge.hpp", line 127:     Where: Instantiated from 
non-template code.
"detail/property_merge.hpp", line 558: Warning: output hides 
boost::polygon::merge_scanline<int, int, 
boost::polygon::polygon_90_set_data<int>, std::set<int>>::output.
"isotropy.hpp", line 183: Error: The function "floor" must have a prototype.
"gtl_boost_unit_test.cpp", line 723:     Where: While instantiating 
"boost::polygon::scale<boost::polygon::interval_data<int>>(boost::polygon::interval_data<int>&, 
double)".
"gtl_boost_unit_test.cpp", line 723:     Where: Instantiated from 
non-template code.
1 Error(s) and 2 Warning(s) detected.

1) you should use std::floor.
2) The is no #include <cstdlib> in isotropy.h.

In Christ,
Steven Watanabe