Subject: Re: [boost] Boost.Atomic request for review/inclusion
From: Phil Endecott (spam_from_boost_dev_at_[hidden])
Date: 2009-12-15 17:58:35
Helge Bahmann wrote:
> First of all I would like to thank for the comments that I have received so
> far, I have incorporated almost all of them I think. Boost.Atomic is now in a
> form that I consider calling it a release. It has support for "true" atomic
> variables on:
> - gcc/x86, 32-bit (tested on Linux, FreeBSD)
> - gcc/x86, 64-bit (tested on Linux)
> - gcc/powerpc32 (tested on Linux, Mac OS X)
> - gcc/powerpc64 (untested)
> - generic Win32 (tested with Visual Studio Express on Win XP)
> For all others it falls back gracefully to locked operation. There is proper
> quickbook documentation, including a hopefully illustrative example section.
> If you have an unsupported platform, contact me and I will attempt to provide
> support for it (usually it is just a matter of testing).
I will have a look at merging my ARM implementation with this ASAP.
git-foo is probably the hardest part.
One thing I mentioned before, which doesn't seem to have changed in
this version, is your use of reinterpret_cast rather than const_cast in
cases like this:
*reinterpret_cast<volatile T *>(&i)=v;
I suggested that this should be const_cast<volatile T&>(i)=v. Any
thoughts? (Anyone else?)
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk