Subject: Re: [boost] [log] Boost.Log formal review result
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2010-03-25 12:15:14
Andrey Semashev wrote:
> On 03/25/2010 01:28 AM, Vladimir Prus wrote:
> I agree to most prerequisites needed for the final inclusion, with a
> sole exception of this one:
> > Critical issues
> > ===============
> > These issues must be addressed, and be passed through
> > informal mini-review,
> > before the library can be added to SVN.
> > - The library should not reinvent wheels. In particular,
> > custom implementations
> > of TSS and RW mutex seems like a very bad idea.
> I have noted that during the review that these tools were implemented
> for a reason. They make the library faster and lighter in terms of
> memory footprint. They allow to avoid including Boost.Thread
> headers in
> public headers of Boost.Log, which also speeds up the compilation. I
> think these matters are more important than having the code
> dispersion they add.
I'd like to know the real effect of using off-the-Boost-shelf components rather than your special sauce. That is, I'd like to know the performance and compilation tradeoffs for them before commenting further.
Rob Stewart robert.stewart_at_[hidden]
Software Engineer, Core Software using std::disclaimer;
Susquehanna International Group, LLP http://www.sig.com
IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk