|
Boost : |
Subject: Re: [boost] Second iteration of Boost.XInt library uploaded, requesting further comments
From: DE (satan66613_at_[hidden])
Date: 2010-03-31 13:26:39
on 31.03.2010 at 5:24
Chad Nelson wrote :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> I've just uploaded the second iteration of the Boost.XInt library to the
> Boost Vault. I very much appreciate all of the comments and suggestions
> everyone has offered on the first one, and I've incorporated a number of
> them.
> Maybe I'm just a masochist, but please take a look and let me know what
> you think.
i find 'nan()' member function confusing
i would have made 'nan()' a static function returning NaN and renamed
the former to 'is_nan()'
similarly 'odd()' and 'even()' could be 'is_odd()' and 'is_even()' but
these are less confusing to me
what others think?
by the way does 'token' produced by 'block_exceptions()' presumes the
previous state? i.e. does its destructor restore the state its
constructor switched from?
and are we going to continue in this thread?
-- Pavel P.S. if you notice a grammar mistake or weird phrasing in my message please point it out
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk