Re: [boost] decltype and incomplete types

Subject: Re: [boost] decltype and incomplete types
From: Eric Niebler (eric_at_[hidden])
Date: 2010-04-09 15:11:50

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 4/8/2010 4:28 PM, Daniel James wrote:
> On 8 April 2010 23:51, Eric Niebler <eric_at_[hidden]> wrote:
>>
>> Thanks. The change should also be applied to truck, otherwise, those of us
>> who use truck testing to know when to merge things to release won't be
>> getting an accurate picture of things.
> 
> That's probably true, although utility hasn't been the same on trunk
> and release for a long time, I merged the result_of changes mainly to
> fix that. I'll leave it Daniel Walker to decide what he wants to go
> from here.

Daniel? Ideally, we should get the other fixes back, but just comment
out the check for BOOST_NO_DECLTYPE and always select the TR1
implementation.

>> Forgive me if I'm sounding ungrateful, but why did you revert those other
>> changes? They seem useful. We only needed to select the TR1 implementation
>> unconditionally. That's a much smaller change.
> 
> To go back to the last state that's known to be good, since they were
> merged together and haven't been tested individually. If we're going
> to use some of the changes, that should be sorted out on trunk first.

Agreed. In fact, that's exactly what I suggested here:
http://article.gmane.org/gmane.comp.lib.boost.devel/202513.

> And I think I should have been more cautious about merging in the
> first place.

It's probably better in general to merge one change at a time, but I
never do that either because it's a PITA. Svn (or svnmerge.py) is too
slow. <sigh>

> It also made it easier to check that I'd correctly reverted the
> changes, since changes to the different parts of utility can get mixed
> up and subversion can sometimes be a bit nutty with merges.

I find svnnmerge.py tends to Just Work as long as you're patient. YMMV.

- -- 
Eric Niebler
BoostPro Computing
http://www.boostpro.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJLv3v2AAoJEAeJsEDfjLbXMQwH/RFAjWBKwf61TJx7J8wN6jWL
4sf3KE40bkvgXsOpFcrmTUoe/IAJf12teXMIrTZpgCvouf/kgDHUIZQX5ech7z1f
aSij1ETHOU6kMN6HeGmvS7Mq38hv5wBWoJBO9U+2aXDevX4/b9MLWbC36rt45CZE
LWDhJ2XlFcRflczp2uslLIPdu1yCRawyNrtfVNczSk36Pt0fA9U2LE00eLfuGLKc
qIQ57mARVy2HccydN79yoHpWKVtj3dY0hA3uSkaVbEKdhhIU34O13F82KRcBLAAX
8s0zP3m5aGhjSIWN/B4jm+Xygjoc26cJ4rJyaiPjZ5Fs9R2mG4/X9f2ojYy+BL0=
=iDXo
-----END PGP SIGNATURE-----