Re: [boost] A Remedy for the Review Manager Starvation

Subject: Re: [boost] A Remedy for the Review Manager Starvation
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2010-05-17 10:45:04

vicente.botet wrote:
>
> The question is who will check that the library meets all the
> review requirements. If I have understood, the review
> withards can not take this completly in account, as this
> check is not an automatic task. So we can have libraries on
> the review schedule that are not ready for review.

Joachim has suggested that is the responsibility of the RMA.  Presently, any author making the request must self-police before making the request.

> This can be also the case for libraries that have a review
> manager. As review manager of the Boost.Task library I can
> say that, when I accepted this role the library
> (Boost.Threadpool was named) was almost ready for review. The
> author changed the library with the intention, of course, of
> improving its own library and now the library is not ready
> for review.
>
> Should I request to remove myself as review manager, as now
> the library is not ready for review?

I don't see that as necessary.

> Should we remove the libraries that are not ready for review
> from the review schedule?

Perhaps that is the wrong way to view this.  Perhaps there should be a two-stage review queue.  The first stage for author's requesting an RMA to look at standards compliance and general review readiness of a proposed library.  The second stage for libraries that have passed the readiness review, possibly need a RM, and can be scheduled at any time.

In such a system, Boost.ThreadPool may not have reached the second stage queue.  If it did, it could have been reverted to the first stage queue due to the rewrite (not due to the name change, of course).

> Should we add a role that checks if the library fullfils the
> review requirements before it is added?

That's the RMA suggestion from Joachim, which I think appropriate.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer, Core Software      using std::disclaimer;
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.