Re: [boost] [Review] Formal Review: Boost.Move

Subject: Re: [boost] [Review] Formal Review: Boost.Move
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2010-05-22 12:48:10

AMDG

I've read straight though the documentation and code.
It looks solid.  I only saw a few trivial issues:

http://igaztanaga.drivehq.com/libs/move/doc/html/move/emulation_limitations.html:
s/overaloading/overloading/

move.hpp:

In the implementation of move, you fully qualify
::boost::disable_if, but not enable_if

Shouldn't the optimized version of forward use identity,
so it won't try to deduce T?

Regarding the use of BOOST_MOVE_OPTIMIZED, I
favor not using this.  I would prefer to avoid unexpected
side-effects even at the cost of some performance, especially
since we can deal with the performance problems by
explicitly moving.

Finally, I vote to accept Boost.Move into Boost.

In Christ,
Steven Watanabe