Re: [boost] [Review] Formal Review: Boost.Move

Subject: Re: [boost] [Review] Formal Review: Boost.Move
From: Ion Gaztañaga (igaztanaga_at_[hidden])
Date: 2010-05-22 14:59:57

On 22/05/2010 18:48, Steven Watanabe wrote:
> AMDG
>
> I've read straight though the documentation and code.
> It looks solid. I only saw a few trivial issues:
>
> http://igaztanaga.drivehq.com/libs/move/doc/html/move/emulation_limitations.html:
>
> s/overaloading/overloading/

Ok, thanks.

> move.hpp:
>
> In the implementation of move, you fully qualify
> ::boost::disable_if, but not enable_if

Ok, thanks.

> Shouldn't the optimized version of forward use identity,
> so it won't try to deduce T?

It should.

> Regarding the use of BOOST_MOVE_OPTIMIZED, I
> favor not using this. I would prefer to avoid unexpected
> side-effects even at the cost of some performance, especially
> since we can deal with the performance problems by
> explicitly moving.

Ok,

> Finally, I vote to accept Boost.Move into Boost.

Thanks Steven,

Ion