Subject: Re: [boost] [units] gcc warnings
From: Steven Watanabe (watanabesj_at_[hidden])
Date: 2010-06-15 10:01:56
Stewart, Robert wrote:
> Jürgen Hunold wrote:
>> /home/hunold/src/devel/boost/boost/units/io.hpp: In function 'int
>> boost::units::get_flags(std::ios_base&, int)':
>> /home/hunold/src/devel/boost/boost/units/io.hpp:163: warning:
>> conversion to
>> 'int' from 'long int' may alter its value [-Wconversion]
>> Patch using an explicit static_cast<int> for the return value
> Do you know that the long int value can never exceed the range of int? If not, the static_cast will simply mask the problem. It would be better to check against std::numeric_limits<int>::max() before casting, and resort to an exception if the range is exceeded.
The maximum value it can have is currently 15.
Anyway, I'll change it to use long consistently.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk