Boost logo

Boost :

Subject: Re: [boost] [optional_io] Request permission to merge simple fix to optional extraction operator
From: Fernando Cacciola (fernando.cacciola_at_[hidden])
Date: 2010-07-20 15:14:44

On 20/07/2010 03:47 p.m., Daniel James wrote:
> On 20 July 2010 19:28, Fernando Cacciola<fernando.cacciola_at_[hidden]> wrote:
>> This is clearly a bug so I can only guess that no one is using it (except
>> for the user that reported it).
>> The fix is quite trivial:
>> And I've updated the test accordingly to make sure it works.
>> Can I marge the fix into the release branch?
> That doesn't look right to me. If the input isn't valid, you should
> set the stream's fail bit, not assert.
So what doesn't look right is the assertion, rather than the important fix which
is the line that reads in the additional character?

I suppose you are right though, regarding what to do when the input is invalid.


Fernando Cacciola
SciSoft Consulting, Founder

Boost list run by bdawes at, gregod at, cpdaniel at, john at