Re: [boost] [Review] Formal Review of Proposed Boost.Ratio LibraryStarts TODAY

Subject: Re: [boost] [Review] Formal Review of Proposed Boost.Ratio LibraryStarts TODAY
From: vicente.botet (vicente.botet_at_[hidden])
Date: 2010-10-05 12:31:56

Hi,
----- Original Message ----- 
From: <nimaca2001_at_[hidden]>
To: <boost_at_[hidden]>
Sent: Tuesday, October 05, 2010 12:23 PM
Subject: [boost] [Review] Formal Review of Proposed Boost.Ratio LibraryStarts TODAY

> 
>> 
>> - What is your evaluation of the design?
>> - What is your evaluation of the implementation?
> 
> Take this as the review from an average C++ user that uses uses simple boost 
> stuff like shared_ptr or bind but is scared of things like MPL or Spirit.
> 
>> - What is your evaluation of the documentation?
> 
> Well written, I would have omitted some appendixes (F and G).

Yes. These two appendixes will be removed once the library is accepted and included on the trunk. I use these to record the tests and the bugs. But these will not be needed as Boost has a more than satisfactory test report and a good trac system.

>> - Did you try to use the library? With what compiler? Did you have any 
> problems?
> 
> Tried the provided samples and some self written one on MSVC 9 without 
> problems
> despite the fact I was using an old version of boost (1.41) as base.

I think the fist version I released (April 09) worked with Boost 1.39, so I'm not surprised it works yet on 1.41. Boost.Ratio don't have too much dependencies.

>> And finally, every review should answer this question:
>> 
>> - Do you think the library should be accepted as a Boost library?
> 
> Yes

Thanks for taking the time to review the library and for your positive result.

Vicente