Subject: Re: [boost] [Boost-users] Subject: Formal Review of Proposed Boost.Process library starts tomorrow
From: Ilya Sokolov (ilyasokol_at_[hidden])
Date: 2011-02-08 04:09:24
On Tue, 08 Feb 2011 13:47:50 +0500, Denis Shevchenko
> 08.02.2011 12:37, Ilya Sokolov Ð¿Ð¸ÑÐµÑ:
>> On Tue, 08 Feb 2011 12:50:59 +0500, Denis Shevchenko
>> <for.dshevchenko_at_[hidden]> wrote:
>>> Of course, with boost::assign ;-)
>> -1. No need to add a dependency in such simple case
> Hm... Dependency from widely used header-only library?
What dependencies that 'widely used header-only library' has?
> So what? Is it problem?
If not, than why not to create boost.hpp header for convenience?
>>> 6. In function boost::process::self::get_environment().
>>> environment e;
>>> // ...
>>> char *env = ms_environ;
>>> while (*env)
>>> std::string s = env;
>>> std::string::size_type pos = s.find('=');
>>> e.insert(environment::value_type(s.substr(0, pos),
>>> s.substr(pos + 1)));
>>> env += s.size() + 1;
>>> catch (...)
>>> // ...
>>> And what kind of exceptions can occur here?
Don't see it called somewhere.
>>> these functions do not throw exceptions...
> In 'try scope' placed code that never throws...
And std::string::string is missing in your analysis, which also throws
'Improving the standard libraryâs exception specifications' by Rani Sharoni
'... The current standard libraryâs exception specifications seems to be
in the sense that many operations that expected to have no-fail guarantee
certain conditions are not explicitly specified as such. ...'
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk