Re: [boost] [xint] Boost.XInt formal review

Subject: Re: [boost] [xint] Boost.XInt formal review
From: Terry Golubiewski (tjgolubi_at_[hidden])
Date: 2011-03-02 16:59:32

On second thought, I don't think copy-on-write is desirable.
Move semantics and references/pointers/smart-pointers give me all the 
capability and control I want while simplifying the implementation (I 
suppose).

terry

----- Original Message ----- 
From: "Terry Golubiewski" <tjgolubi_at_[hidden]>
Newsgroups: gmane.comp.lib.boost.devel,gmane.comp.lib.boost.user
To: <boost_at_[hidden]>
Cc: <boost-users_at_[hidden]>
Sent: Wednesday, March 02, 2011 11:46 AM
Subject: Re: [xint] Boost.XInt formal review

> This is definitely a useful library. Thanks.
> I have a few some comments/suggestions to contribute.
>
> I would prefer than highestbit just returned bitsize_t(-1) or some 
> predefined constant, similar to string::npos.
> Conversion to/from dynamic_bitset would be nice.
> Consider adding a function returning the number of ones in the integer. 
> This could be used to determine parity.
> Consider adding a function to reverse the order of the bits.  "reflect" 
> might be a good name.
> Consider adding conversions to/from floating point types.
> Should integer_traits and numeric_limits be specialized for xint?
> I assume that xint is not thread-safe and just gives the user a way to 
> force a "real" copy for multi-threaded applications (I like it!).
> Consider adding an endian argument to to_binary.  Note that this could 
> affect both the ordering of bits within each byte as well as the ordering 
> of the bytes themselves.  (I actually prefer the libary the way it is, 
> assuming little-endian.)
> I like that xint includes move support.
>
> terry
>
> "Vladimir Prus" <vladimir_at_[hidden]> wrote in message 
> news:201103021358.25190.vladimir_at_codesourcery.com...
>> Boosters,
>>
>> the formal review of the Boost.XInt library, by Chad Nelson, starts now 
>> and will
>> run through March 11.
>>
>> The documentation for the current version is available at:
>>
>> http://www.oakcircle.com/xint_docs/
>>
>> The source code is available via Subversion at:
>>
>> http://svn.boost.org/svn/boost/sandbox/xint
>>
>> or can be downloaded at:
>>
>>
>> http://www.boostpro.com/vault/index.php?action=downloadfile&filename=xint.zip
>>
>> Here are the important points:
>>
>> 1. All comments are appreciated. Even if you don't have the time for 
>> in-depth study
>> of everything, comments on parts of the library are welcome. In 
>> particular, if you
>> are already using logging in your applications and have specialized 
>> requirements,
>> you might want to directly check how the proposed library handles them.
>>
>> 2. The reviews and all comments should be submitted to the developers 
>> list,
>> boost_at_[hidden] and the email should have "[xint]" prefix in the 
>> subject
>> to make sure it's not missed. The deadline for reviews is
>>
>>     23:59, March 11, PST, or
>>     2:59, March 12, EST, or
>>     7:59 March 12, UK time,
>>     10:59, March 12 MSK
>>
>> 3. Please explicitly state in your review whether the library should be 
>> accepted.
>>
>> 4. The general review checklist is provided below:
>>
>>        - What is your evaluation of the design?
>>        - What is your evaluation of the implementation?
>>        - What is your evaluation of the documentation?
>>        - What is your evaluation of the potential usefulness of the 
>> library?
>>        - Did you try to use the library?  With what compiler?  Did you 
>> have any
>>        problems?
>>        - How much effort did you put into your evaluation? A glance? A 
>> quick
>>        reading? In-depth study?
>>        - Are you knowledgeable about the problem domain?
>>
>> Thanks,
>> Volodya
>>
>> -- 
>> Vladimir Prus
>> Mentor Graphics
>> [phone]
>> _______________________________________________
>> Unsubscribe & other changes: 
>> http://lists.boost.org/mailman/listinfo.cgi/boost
>>
>
>
> _______________________________________________
> Unsubscribe & other changes: 
> http://lists.boost.org/mailman/listinfo.cgi/boost
>