Boost logo

Boost :

Subject: Re: [boost] [type_traits] Most Unifying Proposal for operator names Was: Review Typetraits Extension.
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2011-03-24 09:03:42


Joachim Faulhaber wrote:
>
> Comparing the names I tried to find "Most Unifying Proposals" for
> names in column MUP:
>
> https://svn.boost.org/trac/boost/wiki/Guidelines/Naming/Operators

The summary table was helpful, Joachim. Thanks.

Names in the standard are certainly appropriate candidates for use in the Type Traits library, even if I would rather the standard's names were different.

I have some quibbles with your MUP choices, though. For example, you cite std::plus, minus, multiplies, and divides as naming examples from the standard, yet those are the names of function objects, not of operators. Given that Proto uses those names for the operators, there's some precedence for applying them in the traits, but I'd still prefer "addition," "subtraction," "multiplication," and "division" as the traits names. For brevity, and to more closely match the corresponding concept names, "add," "subtract," "multiply," and "divide" would be acceptable.

Similarly, you used the function objects from the C++0x standard as the basis to justify "bit_and," "bit_or," and "bit_xor." Proto uses the better "bitwise_*" forms for the operators.

Editorial comments:

 - For others just reading the table, putting "logical_not" with the other "logical_*" entries would be, well, logical

 - Similarly, putting pre- and post-increment and decrement together would be helpful

 - In the legend: s/MPU/MUP/

_____
Rob Stewart robert.stewart_at_[hidden]
Software Engineer using std::disclaimer;
Dev Tools & Components
Susquehanna International Group, LLP http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.


Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk