Re: [boost] Phoenix: error: extra ‘;’ on boost/phoenix/core/environment.hpp

Subject: Re: [boost] Phoenix: error: extra ‘;’ on boost/phoenix/core/environment.hpp
From: Thomas Heller (thom.heller_at_[hidden])
Date: 2011-05-15 06:47:23

On Saturday, May 14, 2011 09:27:34 PM Eric Niebler wrote:
> On 5/15/2011 12:44 AM, Vicente BOTET wrote:
> > Hi,
> > 
> > There is an error on
> > 
> > In file included from ../../../boost/phoenix/core/call.hpp:12,
> > from ../../../boost/conversion/fp/convert_to.hpp:15,
> > from builtins.cpp:16:
> > ../../../boost/phoenix/core/environment.hpp:446: error: extra ‘;’
> > 
> > It seems that the error: extra ‘;’ are on lines 433 and 444 at the end of 
two functions definitions.
> > 
> > Could this be fixed?
> 
> This is trivial, so I hope Thomas doesn't mind that I just went ahead
> and fixed it. Merged to release as well, since it's pretty safe.

Thanks for fixing this.

> I resisted the urge to fix a bunch of incorrect uses of inline, such as:
> 
> type inline function_name( /*...*/ ) {
> }
> 
> According to (my reading of) the standard, the inline and all other
> so-called function specifiers must come before the return type. Thomas,
> could you please fix this throughout Phoenix?

Right ... It was me being sloppy. Interestingly enough, compilers didn't catch 
this problem. Fixed on trunk.