Re: [boost] [pre-review] Pimpl submission in the review queue

Subject: Re: [boost] [pre-review] Pimpl submission in the review queue
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2011-05-26 07:42:35

Artyom Beilis wrote:
> > From: Vladimir Batov <vb.mail.247_at_[hidden]>
>
> Few points on the tool:
>
> 1. The interface is unfriendly, it is not clear how to write
> review.

You don't.

> 2. There is no place for general feedback, tickets are not good
> model.

Quite right.

> 3. There is no separation into general categories according to
> the way the review generally handled: Design, Implementation,
> Documentation etc.
>
>    Especially notes on design are missing.

There is some room for that, particularly by attaching comments to a line declaring a class, for example.

> 4. There is no way to do a discussion on specific topics.

Indeed.

> 5. There is no place (at least I hadn't found one) to put a
> vote.

Of course.

> This tool would discourage reviewers and make writing reviews
> much harder.
>
> Review is a document that describes the review author's opinion
> on the library that includes a list of issues, it is not a list
> of issues only.
>
> Bug-tracking-like system is not suitable for writing reviews.

All of these are valid points, supposing a tool like Code Collaborator were intended to do what you note it doesn't.  Instead, tools like this provide a means to make comments on specific lines of code or documentation, which are often rather difficult to put into prose or to track once they are.  Furthermore, this particular thread regards a *pre-review* of a library, giving you and the author a chance to iron out issues before the formal review begins.

Normal library reviews, with the usual questions including whether to accept the library or not, are not supposed to be submitted via such a tool.  Doing so would require a highly specialized tool that I've not seen anywhere.

Whether normal reviews are managed via web form, with which we experimented at BoostCon, or are done as now via posts to the mailing list(s), is unclear.  Perhaps both will be supported.

_____
Rob Stewart                           robert.stewart_at_[hidden]
Software Engineer                     using std::disclaimer;
Dev Tools & Components
Susquehanna International Group, LLP  http://www.sig.com

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.