Boost logo

Boost :

Subject: Re: [boost] [review] Heaps
From: Stewart, Robert (Robert.Stewart_at_[hidden])
Date: 2011-06-01 10:14:19

Andrew Sutton wrote:
> > Unlike previous reviews, this review will be assisted by a
> > code review application, Code Collaborator (by SmartBear).
> > The product was tested during a BoostCon session, and we are
> > eager to see how well it scales to a community review. You
> > can use the link below to access and review the Heap library.
> >
> > <>
> Just a quick addendum on this topic... If you are interested in
> reviewing, you should register as a user here:
> You can be formally added as a reviewer to any current review
> by the author or (I think) any other reviewer. I may be wrong
> about the latter, but I was able to add another reviewer this
> morning.

Two additional points:

1. Most participating via Code Collaborator should be "observers," not "reviewers." The latter are expected to "accept" each comment and defect. My suggestion is that the review manager be the sole "reviewer."

2. Code Collaborator should not be used for design level discussion or for the final review message that answers the traditional questions, including whether to accept the library. Instead, Code Collaborator is for commenting on, or marking defects against, particular lines of code or documentation. There is a General Chat area, but that should be used for comments regarding the content actually uploaded, something missing that should have been uploaded, or summary comments on most of the code or documentation. Higher level discussions and formal reviews should be posted to this listed as in the past.

A tool like Code Collaborator, Crucible, etc. that supported threaded discussions and formal reviews would be ideal, but we don't have such a tool at present.

Rob Stewart robert.stewart_at_[hidden]
Software Engineer using std::disclaimer;
Dev Tools & Components
Susquehanna International Group, LLP

IMPORTANT: The information contained in this email and/or its attachments is confidential. If you are not the intended recipient, please notify the sender immediately by reply and immediately delete this message and all its attachments. Any review, use, reproduction, disclosure or dissemination of this message or any attachment by an unintended recipient is strictly prohibited. Neither this message nor any attachment is intended as or should be construed as an offer, solicitation or recommendation to buy or sell any security or other financial instrument. Neither the sender, his or her employer nor any of their respective affiliates makes any warranties as to the completeness or accuracy of any of the information contained herein or that this message or any of its attachments is free of viruses.

Boost list run by bdawes at, gregod at, cpdaniel at, john at