Re: [boost] [1.47.0] Release branch now closed

Subject: Re: [boost] [1.47.0] Release branch now closed
From: Emil Dotchevski (emil_at_[hidden])
Date: 2011-06-14 17:24:44

On Tue, Jun 14, 2011 at 12:06 PM, Rene Rivera <grafikrobot_at_[hidden]> wrote:
> On 6/14/2011 1:41 PM, Emil Dotchevski wrote:
>>
>> Rene, there is a small change in boost/exception/exception.hpp that
>> has been sitting in Trunk for weeks now, I'd like to merge it to
>> release. It just adds GCC visibility to the boost::exception type, and
>> this is the patch:
>>
>> https://svn.boost.org/trac/boost/attachment/ticket/4594/exception.patch
>>
>> I'm ready to commit it if the release team allows it.
>
> Where's the trac link to the change set? Is there a test for this? Is the
> test in the release branch also? What platforms does this impact? What other
> libraries does this impact? Are other libraries failing because of not
> having this change?
>
> Sorry for all the questions, but we need to asses the risk.

No, I hear you, this might be considered too risky at this point.

The change affects GCC only, it makes class boost::exception visible
across shared library boundaries. The header file in question contains
a declaration of boost::exception and a definition of
boost::exception. The definition is already tagged with GCC visibility
(including in the release branch). This change applies the same
settings to the declaration.

Other libraries do not fail because of not having this change. As long
as it compiles, the change should not affect other libraries. It has
been sitting in Trunk for quite some time and hasn't broken anything
AFAIK.

Emil