Re: [boost] [Containers Library Review] The review of the Containers library by Ion Gaztanaga starts today

Subject: Re: [boost] [Containers Library Review] The review of the Containers library by Ion Gaztanaga starts today
From: Ion Gaztañaga (igaztanaga_at_[hidden])
Date: 2011-08-08 04:03:10

El 08/08/2011 6:58, Kohei Takahashi escribió:
> Hi,
>
> My review is here.
>
>>      *  What is your evaluation of the design?
> I think it is important, emulating move semantics and emplace inserter.
>
>>      * What is your evaluation of the implementation?
> Some requirements added in C++0x (see 23.2.1 in n3290). Does
> Boost.Container satisfy, partial or not? (just question) I anxious
> about 23.2.1/8 especially.
> And associated to the requirements, do you have any plans to provide
> allocator_traits?

It implements 23.2.1/8 without allocator_traits. I plan to add 
allocator_traits and C++11 features soon as C++11 features are now stable.

>>      * What is your evaluation of the documentation?
> 1) There are no documentation about free functions. (operators,
> swap, ...

Ok, I'll fix this, although I think they are self-describing.

> 2) The documentation of deque::push_[back|front] are missing.

Thanks for spotting this.

> 3) Some member functions are not documented about Returns/Effects,
> Complexity or Throws. (ex: after No.23 in basic_string) Please check it.

Ok. I'd need to do a full review of all descriptions.

>> And finally, every review should answer this question:
>>
>>      * Do you think the library should be accepted as a Boost library?
> Be
>> sure to say this explicitly so that your other comments don't obscure
> your
>> overall opinion.
> I think should be accepted it with improved documentations.

Thanks.

Best,

Ion