Boost logo

Boost :

Subject: [boost] typos in boost/atomic/details/interlocked.hpp
From: Clark Sims (clark_sims_boost_at_[hidden])
Date: 2011-11-30 21:20:20


It looks like there are a lot of typos in this file.  It would not compile on Visual Studio 2005 for me.  I fixed all the typos, and now I can compile with no problem.

There were lots of cases where the author looks like he forgot to add the variable, order, to the argument list of the function.

< atomic_thread_fence(memory_order order)

---
> atomic_thread_fence(memory_order)
Here is a link to my final version of the file:  http://acumensoftwareinc.com/interlocked.hpp
Here is the diff of the 2 versions:
10d9
< #include <boost/memory_order.hpp>
33c32
< platform_fence_before(memory_order order)
---
> platform_fence_before(memory_order)
38c37
< platform_fence_after(memory_order order)
---
> platform_fence_after(memory_order)
43c42
< platform_fence_before_store(memory_order order)
---
> platform_fence_before_store(memory_order)
55c54
< platform_fence_after_load(memory_order order)
---
> platform_fence_after_load(memory_order)
57,58c56,57
<     if (order == memory_order_seq_cst) {
<         x86_full_fence();
---
>     if (order == memory_order_seq_cst()) {
>         x86_full_fence(void);
89c88
< atomic_thread_fence(memory_order order)
---
> atomic_thread_fence(memory_order)
91,92c90,91
<     if (order == memory_order_seq_cst) {
<         detail::atomic::x86_full_fence();
---
>     if (order == memory_order_seq_cst()) {
>         detail::atomic::x86_full_fence(void)

Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk