Re: [boost] [Release managers] Permission to rollback Boost.Thread breaking changes

Subject: Re: [boost] [Release managers] Permission to rollback Boost.Thread breaking changes
From: Daniel James (dnljms_at_[hidden])
Date: 2013-01-02 10:10:42

On 2 January 2013 14:19, Vicente J. Botet Escriba
<vicente.botet_at_[hidden]> wrote:
> Hi,
> could I merge this change?

Yes, go ahead.

Btw. looking at the test results, some easy (maybe?) fixes:

If vacpp isn't supported, then it should be marked up as such.

This error looks valid, lock_guard doesn't seem to be movable or copyable:

http://www.boost.org/development/tests/trunk/developer/output/Sandia-darwin-4-4_0x-boost-bin-v2-libs-thread-test-make_lock_guard__adopt_lock_p-test-darwin-4-4_0x-debug-threading-multi-sync-mutual_exclusion-locks-lock_guard.html

This test fails because make_unique_locks is only available when
std::tuple is available, it should check that BOOST_NO_CXX11_HDR_TUPLE
is not defined (or maybe use boost::tuple instead?):

http://www.boost.org/development/tests/trunk/developer/teeks99-1a-win7-32on64-thread-msvc-11-0-make_unique_locks__mutex_p-variants_.html