Re: [boost] [Release managers] Permission to rollback Boost.Thread breaking changes

Subject: Re: [boost] [Release managers] Permission to rollback Boost.Thread breaking changes
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2013-01-02 12:24:22

Le 02/01/13 16:10, Daniel James a écrit :
> On 2 January 2013 14:19, Vicente J. Botet Escriba
> <vicente.botet_at_[hidden]> wrote:
>> Hi,
>> could I merge this change?
> Yes, go ahead.

Thanks, done at https://svn.boost.org/trac/boost/changeset/82320.
>
> Btw. looking at the test results, some easy (maybe?) fixes:
>
> If vacpp isn't supported, then it should be marked up as such.
This platform was supported and now it fails without error

Test output:
Rev 82302 / Mon, 31 Dec 2012 15:49:37 +0000
*Report Time: *Wed, 2 Jan 2013 16:06:49 +0000
Compile [2013-01-01 05:04:38 UTC]: succeed

     xlC -F:xlC_r -c     -DBOOST_ALL_NO_LIB=1 -DBOOST_SYSTEM_DYN_LINK=1 -DBOOST_THREAD_BUILD_DLL=1 -DBOOST_THREAD_DONT_USE_CHRONO -DBOOST_THREAD_POSIX -DBOOST_THREAD_THROW_IF_PRECONDITION_NOT_SATISFIED -qcpluscmt -qNOOPTimize -qnoinline -qfullpath -qfuncsect -qeh -qrtti -qxflag=EnableIssue214PartialOrdering:MangleCVOnTemplateTypeArgs:IgnoreCvOnTopOfFunctionTypes:FunctionCVTmplArgDeduction2011 -D__IBM_ALLOW_OVERRIDE_PLACEMENT_NEW -D__IBMCPP_NO_C99_FPCLASSIFY_MACROS__ -D__IBMCPP_NO_C99_FPCOMPARISON_MACROS__ -I".."  -o "/nfs/sparky/home/montana/boost_NEW/boost-CVS/121.aix/results/boost/bin.v2/libs/thread/build/vacpp-12.1.0.1/debug/threading-multi/future.o" "../libs/thread/src/future.cpp"

>
> This error looks valid, lock_guard doesn't seem to be movable or copyable:
>
> http://www.boost.org/development/tests/trunk/developer/output/Sandia-darwin-4-4_0x-boost-bin-v2-libs-thread-test-make_lock_guard__adopt_lock_p-test-darwin-4-4_0x-debug-threading-multi-sync-mutual_exclusion-locks-lock_guard.html
I have fixed it as for
https://svn.boost.org/trac/boost/changeset/82311. The problem is that 
config file doesn't defines BOOST_NO_CXX11_HDR_INITIALIZER_LIST for gcc 
4.4 and 4.5 even if the feature is incomplete as the private overload is 
taken instead of the initializer list overload. The tester that have run 
after this change show that there is no error anymore.
> This test fails because make_unique_locks is only available when
> std::tuple is available, it should check that BOOST_NO_CXX11_HDR_TUPLE
> is not defined (or maybe use boost::tuple instead?):

> http://www.boost.org/development/tests/trunk/developer/teeks99-1a-win7-32on64-thread-msvc-11-0-make_unique_locks__mutex_p-variants_.html
Fixed already with https://svn.boost.org/trac/boost/changeset/82317. See 
tester teeks99-1a-win7-32on64 
<http://www.boost.org/development/tests/trunk/teeks99-1a-win7-32on64.html>.

It is OK to merge both fixes?

Best,
Vicente