|
Boost : |
Subject: Re: [boost] SIMD implementation of uBLAS
From: Joel Falcou (joel.falcou_at_[hidden])
Date: 2013-05-29 01:06:22
On 29/05/2013 06:45, Gaetano Mendola wrote:
> On 29/05/2013 06.13, Aditya Avinash wrote:
>> Hi, i have developed vector addition algorithm which exploits the
>> hardware
>> parallelism (SSE implementation).
>
> A few comments:
>
> - That is not C++ but just C in disguise of C++ code
> . SSE1 CTOR doesn't use initialization list
> . SSE1 doesn't have a DTOR and the user has to
> explicit call the Free method
>
> - const-correctness is not in place
> - The SSE namespace should have been put in a "detail"
> namespace
> - Use memcpy instead of explicit for
> - Why is SSE1 template when it works only when T is a
> single-precision, floating-point value ?
>
>
> Also I believe a nice interface whould have been:
>
> SSE1::vector A(1024);
> SSE1::vector B(1024);
> SSE1::vector C(1024);
>
> C = A + B;
>
>
> Regards
> Gaetano Mendola
>
See our work on Boost.SIMD ...
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk