Subject: Re: [boost] Line endings fixes
From: Vitaly Budovski (vbudovski+news_at_[hidden])
Date: 2013-07-31 19:23:26
I've had a look and the svn:eol-style property seems to be present in
the patches. Perhaps I've missed a file or two?
I've had a look at the dot_gitattributes file and there doesn't seem
to be anything wrong with it. The main issue is that there are a lot
of inconsistencies with files of the same extension, so pretty much no
matter what you change in the .gitattributes you will end up with
issues. For the svg, we could change the type to binary, but that
would potentially create a lot of noisy commits if people regenerate
them on different platforms. It seems like the only proper fix is to
correct the problems at the source. Maybe I've missed something
though. Could you please explain what you had in mind?
On 1 August 2013 01:05, Dave Abrahams <dave_at_[hidden]> wrote:
> The right way to handle this is to submit a pull request against https://github.com/ryppl/Boost2Git/blob/master/dot_gitattributes
> Sent from my moss-covered three-handled family gradunza
> On Jul 31, 2013, at 2:14 AM, JÃ¼rgen Hunold <jhunold_at_gmx.eu> wrote:
>> Hi Vitaly,
>> I'm CC#ing this to Dave as this might go below the radar.
>> On Tuesday, 30. July 2013 00:33:53 Vitaly Budovski wrote:
>>> Please see the attached files. boost_endings1.patch just sets some of
>>> the cpp and other text files to have file endings consistent with the
>>> rest of the repository.
>> Patch applies, but I think svn:eol-styles might be missing.
>>> boost_endings2.patch may be controversial as it does the same but for
>>> the svg files. Some of them are marked as text, others as binary. It's
>>> a real mess. Most of the svg files are generated from other sources so
>>> should probably be omitted from the repository and simply regenerated
>>> when docs are built.
>> eol-style setting here again. Please note that generated documentation is
>> allowed to be checked in.
>>> Came across these issues when checking out the modularised boost git
>> Right, please add [git] to your subject next time to get attention of the
>> conversion team.
>> For the record: Those line endings lead to instant modified git checkout when
>> using modularised boost. I think this is due to the conversion settings and/or
>> missing svn:eol-style.
>> * Dipl.-Math. JÃ¼rgen Hunold !
>> * voice: ++49 4257 300 ! FÃ¤hrstraÃe 1
>> * fax : ++49 4257 300 ! 31609 Balge/Sebbenhausen
>> * jhunold_at_gmx.eu ! Germany
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk