Re: [boost] [signals2] Test failure in C++11 (trivial fix for incorrect usage of boost::optional)

Subject: Re: [boost] [signals2] Test failure in C++11 (trivial fix for incorrect usage of boost::optional)
From: Peter Dimov (lists_at_[hidden])
Date: 2014-02-28 13:30:53

Frank Mori Hess wrote:
> Ok, but when you are going over some code and see "x==false", and decide 
> to refactor it to "!x" for all the reasons you've given, you've just 
> broken the code.  Because they mean completely different things
for optional<bool>.

Well that's correct. But then again, if I decide to refactor 'x == true' 
into 'x', this can also break the code if x is some esoteric type such as 
'int'. :-)