Re: [boost] Boost.Align review begins today

Subject: Re: [boost] Boost.Align review begins today
From: Antony Polukhin (antoshkka_at_[hidden])
Date: 2014-04-14 07:29:40

2014-04-12 7:48 GMT+04:00 Ahmed Charles <acharles_at_[hidden]>:
<...>

> The review of Boost.Align by Glen Fernandes commences today, Friday, 11
> April, and concludes Sunday, 20 April.
>
> Please always state in your review whether you think the library should be
> accepted as a Boost library.
>

Library must be included into the Boost, after minor improvements.

> - What is your evaluation of the design?
>

Good.

> - What is your evaluation of the implementation?
>

Andrey Semashev already pointed out most of the issues. I'd like to add the
following:

1) Looks like include/boost/align/detail/aligned_alloc.hpp in worst case
uses more memory than required

// Looks like we can extract 1 from n1,
// because boost::align in worst case will add
// (alignment - 1) bytes.
std::size_t n1 = size + alignment;

2) BOOST_NOEXCEPT is missing all around the library. This is essential for
copy constructors and gives user more info about method's behavior.

3) Feature request: aligned_allocator_adaptor won't work with allocators
from Boost.Interprocess. I'd love to this this resolved.

This may require additional boost::alignment::align overload for pointer
types used in Boost.Interprocess and a few minor fixes to
aligned_allocator_adaptor.

4) There's no tests for aligned_allocator_adaptor with stateful allocators.
Please add some more tests.

5) Use boost::throw_exception(e) instead of throw e. This will make Align
library usable even with exceptions disabled.

> - What is your evaluation of the documentation?
>

OK. With help of Paul A. Bristow docs will become perfect.

- What is your evaluation of the potential usefulness of the library?
>

Useful. Was missing such functionality a few weeks ago.

> - Did you try to use the library? With what compiler? Did you have any
> problems?
>

No, just looked through the sources and docs.

> - How much effort did you put into your evaluation? A glance? A quick
> reading? In-depth study?
>

Spend more than two hours reading the source codes and docs.

> - Are you knowledgeable about the problem domain?
>

I do know the theory and used a self-made aligned_alloc a few times.

-- 
Best regards,
Antony Polukhin