Re: [boost] Boost.Align review begins today

Subject: Re: [boost] Boost.Align review begins today
From: Glen Fernandes (glen.fernandes_at_[hidden])
Date: 2014-04-17 14:57:29

Antony, thank you.

I've updated the code in the develop branch to address much of the
review feedback.

Source: http://github.com/glenfe/align/tree/develop

1. Now you can include boost/align/<header>.hpp which only puts
identifiers in the "boost::alignment::" namespace. If you include
boost/align.hpp then you will get those identifiers in the "boost::"
namespace.

2. The generic (non-platform specific) aligned_alloc implementation
was changed to be more conservative in memory allocations. In addition
to allocating alignment-1 extra bytes (instead of alignment extra
bytes), it uses std::memcpy to write or read the original pointer
(instead of rounding up alignment to alignof(void*) bytes).

3. The generic (non-platform specific) aligned_alloc implementation
was changed to not be vulnerable to overflow.

4. For aligned_alloc, align, is_aligned, these are now in the
"alignment::" namespace (and not in the "alignment::detail::"
namespace)

5. The aligned_allocator_adaptor implementation was changed to not be
vulnerable to overflow

6. Used BOOST_NOEXCEPT where appropriate.

7. Used BOOST_CONSTEXPR where appropriate.

8. Used boost::throw_exception instead of throw.

9. Added aligned_delete deleter to the library.

10. Used stateful allocator in the aligned_allocator_adaptor unit tests.

... and various other changes for the minor feedback points.

Best,
Glen