Subject: Re: [boost] [EXTERNAL] [mpl] [build] [testing] Merge pull requests
From: Belcourt, Kenneth (kbelco_at_[hidden])
Date: 2014-09-18 23:54:47
On Sep 17, 2014, at 12:39 PM, Andrey Semashev <andrey.semashev_at_[hidden]> wrote:
> There were a lot of discussions about MPL recently, and I created a few pull
> requests to address issues:
Id like to revert the MPL PR that caused our testing problems, and the one Edward just applied. It was wrong of me to commit the PR without any testing. Theres been some list discussion but my overall concern is that we cant clearly explain why some develop testers are broken and others are working okay. The commit completely broke Darwin, Debian, FreeBSD, QNX and Windows. But whats really worrying is that some RHEL testers are still merrily cycling while other RHEL testers are broken. Same for Ubuntu, some are cycling okay while some are broken. I think its too risky to apply a patch when we, honestly I, dont understand why this is happening.
While we could apply Andreys PR (below) Im afraid that may mask real underlying problems that we may not find out about until this hits master, or worse, users. Ill work with Andrey to get the MPL changes applied, perhaps in smaller PRs.
Please let me know if you have concerns.
> Invoke 'headers' target before building testing tools. Note that several
> testers are currently failing to run because of this problem. Since this
> affects the testing process, I'd appreciate if someone familiar with it could
> take a look.
> Add MPL.Core tests to the test report. These tests are currently not run by
> Move a misplaced header from MPL to MPL.Core to resolve circular dependency
> between the two.
> I believe the first PR is especially critical. Could someone with permissions
> merge these?
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk