Re: [boost] [review] Last day for formal review for Sort library

Subject: Re: [boost] [review] Last day for formal review for Sort library
From: Steven Ross (spreadsort_at_[hidden])
Date: 2014-11-23 07:00:11

Dupuis,

>>Consider for example :
> >>
> >>  // --------------- Start of code snippet ------------------------
> >>  struct Md5Sum {
> >>       uint8_t bytes[16];
> >>
> >>       bool operator<(const Md5Sum& md5) const {
> >>           for (int k = 0; k < 16; k++)
> >>               if (bytes[k] < md5.bytes[k])
> >>                   return true;
> >>          return false;
> >>       }
> >>  };
> >>
> >
> >This seems very similar to the structure example at the bottom of
> >string_sort.html. How is this example superior to that one?
> Very similar. In that case, it was not immediately obvious to me that I
> could use string_sort() to sort binary data. Perhaps adding a sentence
> to that effect in the introduction or overloading section would be nice.
>

That's a good point.  I've added a mention that it can sort binary data to
the introduction for string_sort, and a mention that string_sort can sort
anything with a strict weak ordering that std::sort can sort to the library
introduction.