Subject: Re: [boost] [Review] Boost.Endian mini-review
From: Philip Bennefall (philip_at_[hidden])
Date: 2015-01-23 16:26:06
This is my first time reviewing a Boost library, so I figured a
mini-review might be a good place to start.
I did not look at the library during the formal review, so I am
approaching it as a new user. I have read through the documentation and
parts of the reference, and I think it looks good. The documentation
does a good job of explaining the pros and cons of the three usage
patterns, and I am happy with the performance measurements. I also
looked through the source, and was pleasantly surprised to see the
modest dependency list. That's a deal-breaker for me when deciding which
Boost libraries to use.
One thing I was not quite clear on is, what features are disabled in
C++03 mode? Can this be clarified a little?
I was happy to find the support for unaligned types with byte sizes
other than 1, 2, 4 and 8. This, in combination with dynamic_bitset,
would have been very useful when I implemented a MIDI file parser a
little while ago.
In my view, an endianness library should have been in Boost 10 years
ago. I vote for acceptance.
On 1/23/2015 5:17 PM, Joel FALCOU wrote:
> The mini-review of Boost.Endian starts today and runs through Sunday,
> February 1.
> The library repository is available on GitHub at
> The docs for the library can be viewed online at
> The objective of the mini-review is to verify that the issues raised
> during the formal review have been addressed. Those issues are
> documented at https://boostorg.github.io/endian/mini_review_topics.html
> which also describes the resolution of each issue.
> Comments and suggestions unrelated to the mini-review issues are also
> welcome, but the key question the review manager needs your opinion on
> is this:
> Is the library ready to be added to Boost releases?
> -- Joel Falcou, Endian Review Manager
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost