Re: [boost] [ boost ] [ Trie ]

Subject: Re: [boost] [ boost ] [ Trie ]
From: Cosmin Boaca (boost.cosmin.boaca_at_[hidden])
Date: 2015-02-27 07:01:43

Hello,

I have managed to remove the template parameters and get all the tests
compiling and running [0]. Also, I have fixed the begin, end, rbegin(),
rend() functions from trie_set / trie_multiset [1] and I have used std::ref
in operator* only when the compiler supports rvalue references[2].
The solution with make_pair<vector<key_type>, Value&> works only on non
C++11 compilers, because on C++11 reference is removed from the return_type
of make_pair in C++11.

Please review the code if you have time and tell me what should I do next.
I think a move constructor for C++11 compilers would be a nice addition.

[0]
https://github.com/cosminBoaca/boost.trie/commit/f9e0800c8dcc73a615e73a87175f761cdc2180b1
[1]
https://github.com/cosminBoaca/boost.trie/commit/a3eeae277470788cbec6ccba2aaeebe9268107d1
[2]
https://github.com/cosminBoaca/boost.trie/commit/1bfda5490e18e3bcd51ec86883aff29e6fd0fcd8

Thank you,
Cosmin