Re: [boost] [Boost-announce] [metaparse] Review period starts May 25th and ends June 7th

Subject: Re: [boost] [Boost-announce] [metaparse] Review period starts May 25th and ends June 7th
From: Peter Dimov (lists_at_[hidden])
Date: 2015-06-02 13:32:06

Abel Sinkovics wrote:

> This repository can be found here: https://github.com/sabel83/metaparse

What follows is my review of Metaparse.

> - What is your evaluation of the design?

Of high quality. Based on the MPL paradigm, but I don't view this as a 
problem.

> - What is your evaluation of the implementation?

Did not look in detail, but based on a cursory glance, appears to be of 
Boost quality.

> - What is your evaluation of the documentation?

Very good.

> - What is your evaluation of the potential usefulness of the library?

Looks very useful for its target domain. I especially like the Grammar 
(meta)feature, using which one can provide the grammar description as text.

> - Did you try to use the library?

No.

> - How much effort did you put into your evaluation?

I read the documentation in its entirety (minus the Tutorial) and some of 
the supporting material.

> - Are you knowledgeable about the problem domain?

I'm not sure if anybody is. :-)

> Please always include in your review a vote as to whether the library 
> should be accepted into
Boost.

I think that the library should be accepted, although the name BOOST_STRING 
is too ambitious. I suggest BOOST_MP_STRING.