Subject: Re: [boost] [Fit] formal review ends today, 13th March.
From: Vicente J. Botet Escriba (vicente.botet_at_[hidden])
Date: 2016-03-13 20:07:44
Le 13/03/2016 20:37, Manu SÃ¡nchez a Ã©crit :
> I have been checking both the library (I have not used Fit for eight months
> or so, so I had to be sure I didn't miss anything) and the review the whole
> week, but I haven't had enough time to formalize a review.
> My opinion is, as others stated, that Fit is useful (function composition,
> lifting, tools, etc) and has quality enough to be incorporated into Boost.
> My only concern, first noticed by Louis Dionne IIRC, is that constexpr
> lambda objects are not constexpr-evaluated. This may be obvious for experts
> like us, but might be a source of misconception for newcomers. Until C++17
> fixes this with constexpr lambdas a documentation note clarifying it should
> be enough. Of course such a detail is not a reason for rejection, my
> opinion is that Fit should be accepted unconditionally.
> Hope it helps.
I believe that we will extend the review until the 20th so that we can
have more reviews, the goal being to improve the library before
acceptance into Boost.
I need confirmation from the Review Withards, but anyway I will take any
late review into consideration.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk