Re: [boost] [lockfree] _ENABLE_ATOMIC_ALIGNMENT_FIX for VS 2015Update 2

Subject: Re: [boost] [lockfree] _ENABLE_ATOMIC_ALIGNMENT_FIX for VS 2015Update 2
From: Billy O'Neal (VC LIBS) (bion_at_[hidden])
Date: 2016-05-10 19:39:14

>doesn't the compile error tells us that this is not the case here?

If you are triggering that warning then the resulting code was broken (that is, not atomic) before. It's not a bincompat break if it never actually worked.

Billy O'Neal III
SDE - Visual C++ Libraries
________________________________________
From: Boost <boost-bounces_at_[hidden]> on behalf of Tim Blechmann <tim_at_[hidden]>
Sent: Tuesday, May 10, 2016 4:35:04 PM
To: boost_at_[hidden]
Subject: Re: [boost] [lockfree] _ENABLE_ATOMIC_ALIGNMENT_FIX for VS     2015Update 2

>> BTW, I thought MSVC did not guarantee ABI compatibility between
>> different versions? Did this change?
>
> We guarantee bincompat between Updates. We break it between major
> versions.

doesn't the compile error tells us that this is not the case here?

> VS 2015 Update 2 was fixed to handle this correctly, but the fix
> inherently changes layout and breaks binary compatibility. Please
> define _ENABLE_ATOMIC_ALIGNMENT_FIX to acknowledge that you
> understand this, and that everything you're linking has been compiled
> with VS 2015 Update 2 (or later).

in my interpretation of this the update breaks binary compatibility and
by default rejects valid code.

_______________________________________________
Unsubscribe & other changes: https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2flists.boost.org%2fmailman%2flistinfo.cgi%2fboost&data=01%7c01%7cbion%40microsoft.com%7cadae602e54b74ea0d2cd08d3792bbf94%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=CS8gT%2fMRcG4NNqVHTlf6M24xtibfvnGU3iv8z79OFhg%3d