Re: [boost] [review][Fit] Review of Fit starts today : September 8 - September 17

Subject: Re: [boost] [review][Fit] Review of Fit starts today : September 8 - September 17
From: paul (pfultz2_at_[hidden])
Date: 2017-09-20 14:52:32

On Tue, 2017-09-19 at 23:26 -0500, Barrett Adair via Boost wrote:
> On Fri, Sep 8, 2017 at 6:02 AM, Matt Calabrese via Boost <
> boost_at_[hidden]> wrote:
> > 
> > 
> > A formal review of the Fit library developed by Paul Fultz II starts
> > today, September 8, and runs through September 17.
> > (snip)
> I recommend to ACCEPT the Fit library into Boost unconditionally.

Thanks you for the review.

> 
> > 
> > Â  - What is your evaluation of the design?
> I like it.
> 
> > 
> > Â  - What is your evaluation of the implementation?
> Have not reviewed in recent times. I'm very impressed with the claimed
> compiler support, although I'm curious to know how Clang 4 and Clang 5 fare.

I have tested on newer clang versions, but I don't have them in my travis CI
to regularly test. There always seemed to be an issue using LLVM's apt repo.

> 
> I realize the importance of an implementation review for this library, so I
> trust that Matt will weigh this lightweight review appropriately.
> 
> > 
> > Â  - What is your evaluation of the documentation?
> Good. I would like to see pound-include lines added to all of the early
> examples. So many times as a user of Boost I have had to cross reference
> example code with the reference docs just to find the include path, which
> is annoying.
> 
> > 
> > Â  - What is your evaluation of the potential usefulness of the library?
> Very useful! I would have used this a handful of times at work already, had
> it been available in Boost.
> 
> > 
> > Â  - Did you try to use the library? With which compiler(s)? Did you
> > Â Â Â Â have any problems?
> No, at least not recently.
> 
> > 
> > Â  - How much effort did you put into your evaluation? A glance? A quick
> > Â Â Â Â reading? In-depth study?
> Tonight, about an hour reading documentation. Cumulatively, several hours
> over the past couple of years. I have been following Fit since before the
> 2016 review, so I'm thrilled to see it up for review again.
> 
> > 
> > Â  - Are you knowledgeable about the problem domain?
> Yes, although my experience with functional programming is mostly limited
> to TMP.
> 
> > 
> > Â  - Were the concerns from the March 2016 review of Fit addressed?
> N/A
> 
> Barrett Adair
> 
> _______________________________________________
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boo
> st