Re: [boost] Help wanted: Open pull request reminders

Subject: Re: [boost] Help wanted: Open pull request reminders
From: John Maddock (jz.maddock_at_[hidden])
Date: 2017-10-24 11:19:00

> The amount of pull requests, most of which are really old, is quite scary.
> Do people not care about merging fixes in their code?

Not all fixes are created equally: some are incomplete and the author 
may be waiting on more information.  Others may be work in progress: I 
have some against my stuff that begin with "Please don't merge yet, work 
in progress" or words to that effect.  OK, I could just close them down 
on the grounds that they're not ready yet, but in most cases the authors 
of those PR's are actually working on them (or intending to do so).  So 
there is an inevitable bind up of cruft: stuff that isn't a simple no 
brainer "yes I can merge this as is".  Indeed some are very significant 
changes which require a fair bit of work before they can be merged, I 
don't necessarily want to close them as "won't apply", but I don't 
necessarily have the time to apply them correctly either just yet - so 
they'll sit there until I do.  In an ideal world we would have a third 
status to "open" and "closed", something like "pending" or "waiting for 
information".

John.

---
This email has been checked for viruses by AVG.
http://www.avg.com