Re: [boost] [cmake] Pull request announcement

Subject: Re: [boost] [cmake] Pull request announcement
From: Barrett Adair (barrettellisadair_at_[hidden])
Date: 2018-09-19 05:02:09

On Tue, Sep 18, 2018, 11:23 Zach Laine <whatwasthataddress_at_[hidden]> wrote:

> On Tue, Sep 18, 2018 at 10:52 AM Roger Leigh via Boost <
> boost_at_[hidden]> wrote:
>
>> On 18/09/18 16:43, Zach Laine via Boost wrote:
>>
>> One possibility:
>>
>> if(NOT TARGET check)
>>    create_custom_target(check DEPENDS foo-check)
>> else()
>>    add_dependencies(check foo-check)
>> endif()
>>
>> The top-level CMakeLists.txt would need to define an empty check target
>> up front which the else() case will add the local check target to.
>>
>
> I like this. Louis and Barrett, if I were to make a PR for each of your
> repos, would you find this acceptable too?
>

Yes, that seems like a nice way to resolve this conflict.

>