Re: [1.72][Test][Math][Fiber] Recent breaking change in Boost.Test breaks fiber/math tests

From: pbristow_at_[hidden]
Date: 2019-11-05 12:41:35

> -----Original Message-----
> From: Boost <boost-bounces_at_[hidden]> On Behalf Of Raffi Enficiaud via
> Boost
> Sent: 4 November 2019 22:57
> To: boost_at_[hidden]
> Cc: Raffi Enficiaud <raffi.enficiaud_at_[hidden]>
> Subject: Re: [boost] [1.72][Test][Math][Fiber] Recent breaking change in Boost.Test
> breaks fiber/math tests
> 
> On 04.11.19 19:59, John Maddock via Boost wrote:
> > This change:
> > https://github.com/boostorg/test/commit/1c4533f7654d4c049cc6a34a43a5c1
> > 0cde5bdd8b#diff-efad11c1b810a644deec92a42abe330e
> 
> Oh, sorry about that. Reverting the lines right now.

Actually I like the change - did we need 'framework'?

Anyone using this is perhaps relying on a detail?

(The need for it in the Math test case was to ensure that the BOOST_TEST_MESSAGE("my_message") were actually visible.  I think it would be better if messages were visible by default, not something one needs to ask for specially.  I also was unconvinced the setting the environment variable BOOST_TEST_MESSAGE worked but I'll check this out and raise a bug report.)

But definitely a note in the release notes would be good.

The 'fix' is to rename 
  unit_test_framework::
to
  unit_test:: 

Paul

> > To Boost test (which I'm sure has been long signaled, I just wasn't
> > aware of it), breaks one Math lib test (develop and master), and quite
> > a number of Fibre tests (also develop and master), the Math failure
> > should be fixed in develop
> > (https://github.com/boostorg/math/commit/1d04bf714e809d386088ce135e3f9
> > ea04caac2b8) and will get merged to master once CI is green.  Not sure
> > if anything is in the works for Fiber.
> >
> > Just a wee heads-up.
> >
> > Best, John.
> >
> >
> 
> 
> 
> _______________________________________________
> Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost