Re: [1.72][Test][Math][Fiber] Recent breaking change in Boost.Test breaks fiber/math tests

From: pbristow_at_[hidden]
Date: 2019-11-05 16:03:43

> -----Original Message-----
> From: Boost <boost-bounces_at_[hidden]> On Behalf Of Paul A Bristow via
> Boost
> Sent: 5 November 2019 12:42
> To: boost_at_[hidden]
> Cc: pbristow_at_[hidden]
> Subject: Re: [boost] [1.72][Test][Math][Fiber] Recent breaking change in
Boost.Test
> breaks fiber/math tests
> 
> 
> 
> > -----Original Message-----
> > From: Boost <boost-bounces_at_[hidden]> On Behalf Of Raffi
> > Enficiaud via Boost
> > Sent: 4 November 2019 22:57
> > To: boost_at_[hidden]
> > Cc: Raffi Enficiaud <raffi.enficiaud_at_[hidden]>
> > Subject: Re: [boost] [1.72][Test][Math][Fiber] Recent breaking change
> > in Boost.Test breaks fiber/math tests
> >
> > On 04.11.19 19:59, John Maddock via Boost wrote:
> > > This change:
> > > https://github.com/boostorg/test/commit/1c4533f7654d4c049cc6a34a43a5
> > > c1 0cde5bdd8b#diff-efad11c1b810a644deec92a42abe330e
> >
> > Oh, sorry about that. Reverting the lines right now.
> 
> Actually I like the change - did we need 'framework'?
> 
> Anyone using this is perhaps relying on a detail?
> 
> (The need for it in the Math test case was to ensure that the
> BOOST_TEST_MESSAGE("my_message") were actually visible.  I think it would be
> better if messages were visible by default, not something one needs to ask for
> specially.  I also was unconvinced the setting the environment variable
> BOOST_TEST_MESSAGE worked but I'll check this out and raise a bug report.)

I've finally found this exchange explaining the behaviour.

http://boost.2283326.n4.nabble.com/test-Problem-with-BOOST-TEST-MESSAGE-td467539
8.html

I think it is very counter-intuitive that messages only emerge to the normal
output if there is an error or --log_level="message"

And that 

   #define BOOST_TEST_LOG_LEVEL "message"

 does not appear to have the same effect as --log_level="message"

which is also surprising, and in my book a buglet?

I suggest that this behaviour should be changed so that BOOST_TEST_MESSAGE
*always* produces output.

BOOST_AUTO_TEST_CASE(test_message)
{
   BOOST_TEST_MESSAGE("\nTest BOOST_TEST_MESSAGE.\n");
} // BOOST_AUTO_TEST_CASE(test_message)

boost_test_message_test.vcxproj ->
I:\Cpp\math\x64\Release\boost_test_message_test.exe

should output

Running 1 test case...

Test BOOST_TEST_MESSAGE.

*** No errors detected

Otherwise I am sure I will not be the only person confused.

At the very least the documentation should highlight that ones expectation may
not match what actually happens.

Paul