Re: [Boost] [Describe] Review

From: Peter Dimov (pdimov_at_[hidden])
Date: 2021-03-10 17:44:25

Alexander Grund wrote:
> - All tests are silently skipped if C++(14) support is not good enough ("silently"
> as in b2 they will be reported as "run" although nothing is done)

I changed that recently on purpose, as the library is intended to be "usable"
(that is, not cause compilation errors) if types are described under C++11.

The describe_* primitives don't return anything then, of course, but this makes
it possible to BOOST_DESCRIBE types without having to #ifdef.

> - requirement for gnu++14 on GCC < 8 is also very odd for a Boost lib.
> I'm not sure what is supposedly missing here, but at least the enum stuff seems
> to fundamentally work at least: https://godbolt.org/z/n3foGn

The ##__VA_ARGS__ extension is not supported. See https://godbolt.org/z/hc3eEv.

The default for g++ 6/7 when no -std is given is gnu++14, so I expect this to
cause less trouble than one would ordinarily expect. Of course it would have
been better for the library to just work, but I don't know how to fix it. (I've
already learned way too much preprocessor programming than the WHO
recommends.)

Thank you for the other observations, they are appreciated.

(And thanks to all other reviewers, of course.)