From: Andrey Semashev (andrey.semashev_at_[hidden])
Date: 2022-08-03 08:40:56
On 8/3/22 08:39, Marshall Clow via Boost wrote:
> On Aug 2, 2022, at 7:37 AM, Nathaniel Groendyk via Boost <boost_at_[hidden]> wrote:
>> Hi all,
>> I'd like to merge bugfix: https://github.com/boostorg/asio/pull/394
>> which fixes: https://github.com/chriskohlhoff/asio/issues/1098
>> However, I am not sure if this is the proper workflow for submitting
>> proposed fixes (I am new to contributing to boost), but thought I would
>> post it here just to bring it to attention before master is closed.
>> If I am in err, could someone point me to any docs about the proper
>> workflow for submitting a bugfix :)
> Youâve made a good start.
> You submit a PR against the develop branch of some library (ASIO, in this case). Ok, youâve done that.
> The owner of the library reviews/approves/rejects/asks for revisions of the PR. That doesnât appear to have happened.
> The PR gets merged to the âdevelopâ branch. This hasnât happened, either.
> The CI tests run. The test bots run. The results are inspected.
> When the tests look good, the library owner merges the change is âdevelopâ into âmasterâ, where it shows up in a release.
This is how it works for most libraries, but not for Boost.ASIO in
particular. ASIO is being developed at
https://github.com/chriskohlhoff/asio, so that's where you originally
submit the PR or otherwise try to integrate your changes. Then Chris
will generate Boost.ASIO from that project, and at that point the fix
will propagate to Boost.
Boost list run by bdawes at acm.org, gregod at cs.rpi.edu, cpdaniel at pacbell.net, john at johnmaddock.co.uk