Re: [hash2][review] Early review (due to holidays)

From: Claudio DeSouza (cdesouza_at_[hidden])
Date: 2024-12-04 13:35:45

There has been some discussion about this and the consensus is that
`uint8_t` is a better option than `std::byte` as the former represents a
determinate number of bytes (
https://isocpp.org/wiki/faq/intrinsic-types#bits-per-byte). So `span<const
uint8_t>, and `span<uint8_t>` for immutable and mutable bytes respectively.

On Wed, Dec 4, 2024 at 1:03 PM Dominique Devienne <ddevienne_at_[hidden]>
wrote:

> On Wed, Dec 4, 2024 at 2:09 AM Claudio DeSouza via Boost
> <boost_at_[hidden]> wrote:
> > function that takes a pair of void*/size_t should be a span<uint_8>
>
> or rather `std::span<[const ]std::byte>`. --DD
>
> https://en.cppreference.com/w/cpp/types/byte
> https://en.cppreference.com/w/cpp/container/span/as_bytes
>