Re: [hash2][review] Early review (due to holidays)

From: Ivan Matek (libbooze_at_[hidden])
Date: 2024-12-04 14:05:57

On Wed, Dec 4, 2024 at 2:36 PM Claudio DeSouza via Boost <
boost_at_[hidden]> wrote:

> There has been some discussion about this and the consensus is that
> `uint8_t` is a better option than `std::byte` as the former represents a
> determinate number of bytes (
> https://isocpp.org/wiki/faq/intrinsic-types#bits-per-byte). So `span<const
> uint8_t>, and `span<uint8_t>` for immutable and mutable bytes respectively.
>
>
I presume think static_assert for CHAR_BIT value is enough, I am not aware
of anybody using systems where this is not true, despite what faq says...
but I must admit I am not familiar with all weird archs so I could be wrong