Re: [hash2] Formal Review Begins

From: Christopher Kormanyos (e_float_at_[hidden])
Date: 2024-12-10 20:37:50

 >> What I'd like to see short-term:
>>Â  * Handle enhanced compiler warnings.

> Would you please go into more detail here?
> We currently test with -Wall -Wextra.

Yes. I would like to. I appreciate
and benefit from (at bare minimum in GCC):

-Wall -Wextra -Wpedantic -Wconversion -Wsign-conversion

And sometimes I even go for -Werror

You would face a much larger onslaught
of warnings with a commercial-grade CERT-C++
checker, so that set above is actually
rather slack in my world. I can provide
qan actual build-log with line numbers
if needed. Or I can just PR the changes
if you like.

The whole warning-game is just like, hey,
why the noise? 90% of the warnings
are useless, but every once in a while you
get a nugget that (might) prevent you
a really big crash. So I just activate
a bunch of warnings, handle them all and
simultaneously weed out the good stuff.

Here is my typical warning set "on the metal"
real-time-cpp/ref_app/target/app/make/app_make.gmk at 8cc0ce3dd26c30eeba21a1826716f7604f5ef2e4 · ckormanyos/real-time-cpp

| 
| 
| 
|  |  |

 |

 |
| 
|  | 
real-time-cpp/ref_app/target/app/make/app_make.gmk at 8cc0ce3dd26c30eeba...

Source code for the book Real-Time C++, by Christopher Kormanyos - ckormanyos/real-time-cpp
 |

 |

 |

Kind regards, Christopher

   On Tuesday, December 10, 2024 at 09:28:10 PM GMT+1, Peter Dimov via Boost <boost_at_[hidden]> wrote:  
 
 Christopher Kormanyos wrote:

> But here comes the fun part. When I studied the implementation it seemed
> highly portable.
> So I put it onto several embedded bare-metal systems. The code compiled and
> ran on 32-bit microcontrollers and even ran on an 8-bit controller. Rarely do
> we find such portability and quality in Boost-proposed libraries, or anywhere
> for that matter. Kudos on a job well done!

Thanks Christopher. :-)

> What I'd like to see short-term:
>Â  * Handle enhanced compiler warnings.

Would you please go into more detail here? We currently test with -Wall -Wextra.

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost