Re: [hash2] Formal Review Begins

From: Peter Dimov (pdimov_at_[hidden])
Date: 2024-12-10 20:54:52

Ion Gaztañaga wrote:
> El 10/12/2024 a las 1:47, Peter Dimov via Boost escribió:
> > Peter Turcan wrote:
> >> 1. Just a little confused as to the name "Hash2" when there is no "Hash1" ?
> >> Perhaps this was explained earlier and I missed it.
> >
> > "Hash1" is the library formerly known as Functional/Hash, and now
> > named ContainerHash. It defines the function object boost::hash.
> >
> > (Whereas Hash2 defines its stuff in namespace boost::hash2.)
> 
> Since Hash2 depends on ContainerHash for several traits and functions both
> have the same dependencies (Config, Assert, Describe, Mp11), and both are
> about hashing... Wouldn't make sense to merge both libraries into a single
> Hash library?

Maybe, eventually. ContainerHash doesn't accept a seed at the moment,
and there isn't that much to be gained by the merge. We also have existing
hash_value overloads in user code, and these have to continue working.