Re: [ublas] [patch] bug in matrix_binary::const_interator::operator +=

From: Gunter Winkler (guwi17_at_[hidden])
Date: 2005-06-29 10:36:33

Am Dienstag, 28. Juni 2005 18:01 schrieb Michael Stevens:
> On Friday 24 June 2005 13:38, Gunter Winkler wrote:
> > the bug found by Vardan was caused by a wrong implementation of
> > operator += () and operator -= () of matrix_binary. The increment
> > and decrement operators were already dispatched depending on the
> > underlying iterator types, but the += and -= had the old behavior.
> > The patch includes the quick fix to call ++ or -- as often as
> > requested.
>
> I'm not sure if I should commit this now or wait for the full fix.
> I'm not sure what efficiency we will loose in the common cases. If +=
> is commonly used then fix will really slow some things down.

I would not commit the patch, because its a quick & dirty fix. But We 
should add an issue at the bug tracker or todo list.

mfg
GUnter