- Boost - lists.boost.org

Serialization Formal Review #2 -- Review Period Closed
by Jeff Garland 27 Apr '04

27 Apr '04

The review period for the Serialization library is now over. Thanks to all the reviewers for their time in reviewing the library. Reviewers were unanimous in voting to accept the library. As a result, Serialization will be accepted into Boost. It will take me about a week to post a summary of the review comments and requested changes. And finally, thanks again to Robert for his unyielding effort to bring this library to Boost! Jeff

1 0

[iterator + named params] includes #error
by Vladimir Prus 27 Apr '04

27 Apr '04

When I try to compile the following code: #include <boost/named_params.hpp> #include <boost/iterator/transform_iterator.hpp> I get: ghost@zigzag:/tmp$ g++ -I ~/Work/boost -I ~/Work/boost-sandbox np.cpp In file included from /home/ghost/Work/boost/boost/iterator/detail/enable_if.hpp:15, from /home/ghost/Work/boost/boost/iterator/transform_iterator.hpp:14, from np.cpp:3: /home/ghost/Work/boost/boost/iterator/detail/config_def.hpp:22:3: #error you have nested config_def #inclusion. I suspect that the attached patch might need to be applied, but since I don't understand 'config_def.hpp' I though I'd ask first. - Volodya

1 0

[serialization, bind, vc7.1]
by Alexey Nikitin 27 Apr '04

27 Apr '04

Next example (only 2 lines) not compiled: ---- t120.cpp ----- #include <boost/bind.hpp> #include <boost/archive/text_iarchive.hpp> -------------------- D:\Alnik\cpp>cl /c /GX t120.cpp Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 13.10.3077 for 80x86 Copyright (C) Microsoft Corporation 1984-2002. All rights reserved. t120.cpp C:\Alnik\heap\boost\boost-dev\boost\mpl\less.hpp(39) : error C2760: syntax error : expected ',' not ';' C:\Alnik\heap\boost\boost-dev\boost\mpl\less.hpp(51) : see reference to class template instantiation 'boost::mpl::less<T1,T2>' being compiled C:\Alnik\heap\boost\boost-dev\boost\mpl\less.hpp(39) : error C2144: syntax error : 'const bool' should be preceded by '}' C:\Alnik\heap\boost\boost-dev\boost\mpl\less.hpp(39) : error C2062: type 'const bool' unexpected C:\Alnik\heap\boost\boost-dev\boost\mpl\less.hpp(39) : error C2238: unexpected token(s) preceding ';' C:\Alnik\heap\boost\boost-dev\boost\mpl\less.hpp(42) : error C2065: 'value' : undeclared identifier But if to rearrange lines then compiled. Is this the bug of compiler? Regards, Alexey.

2 1

logging library?
by John Torjo 27 Apr '04

27 Apr '04

Dear boosters, I know a while ago there was some interest in a logging library. And of course, there are so many ways you can do logging, that it was somehow agreed that a unique logging library can't address them. However ;), recently I discovered a very easy way to do logging. Gradually, I've come to this class (shown at the end). Using it is extremely easy, and it totally decouples what you write from where it's written. The idea is to have a function that takes a const std::string& parameter, and it will be called whenever a new message is logged. If you want thread-safety, it's just too simple... Just implement it within your function. Example: // log.h logstream errors_log(); logstream activity_log(); // log.cpp void do_log( const std::string & msg) { // ... thread-safe writing to cout scoped_lock lock(some_static_mutex); std::cout << msg; std::cout.flush(); } logstream errors_log() { return logstream(&do_log) << "[ERROR] "; } logstream activity_log() { return logstream(&do_log) << "[activity] "; } // in code #include "log.h" activity_log() << "application started (" << ver.major_ver << "." << ver.minor_ver << ")" << std::endl; errors_log() << "too many users" << users << std::endl; // etc. Also, I have an idea of how to enable/disable (parts of) logging at runtime. Same for very easily enabling/disabling logging of different modules. Any interest in such a library? Best, John #ifndef LOG_LOGSTREAM_HPP #define LOG_LOGSTREAM_HPP #pragma once // Copyright (c) John Torjo - 2004 #include <iosfwd> #include <sstream> namespace log { // allow finding the prototype for a log function template<class char_type, class traits = ::std::char_traits<char_type>, class aloc = ::std::allocator<char_type> > struct log_func { typedef void (*type)(const std::basic_string<char_type,traits,aloc> &); }; // allow writing to a log template<class char_type, class traits = ::std::char_traits<char_type>, class aloc = ::std::allocator<char_type> > struct basic_logstream { typedef typename log_func<char_type,traits,aloc>::type log_func_type; typedef ::std::basic_ostringstream<char_type,traits,aloc> ostring_stream_type; explicit basic_logstream( log_func_type func) : m_func(func) {} basic_logstream( basic_logstream & other) : m_func(other.m_func) { m_buffer << other.m_buffer.str(); other.m_func = 0; } ~basic_logstream() { if ( m_func) m_func( m_buffer.str() ); } template< class T> basic_logstream & operator<<( const T & val) { m_buffer << val; return *this; } typedef std::ostream & (*ostream_func)(std::ostream & ); basic_logstream & operator<<( ostream_func f) { f( m_buffer); return *this; } private: ostring_stream_type m_buffer; log_func_type m_func; }; typedef basic_logstream<char> logstream; typedef basic_logstream<wchar_t> wlogstream; } #endif

7 19

[iterator] concept checking for transform_iterator
by Vladimir Prus 27 Apr '04

27 Apr '04

I've just passed argument to make_transform_iterator in the wrong order, and could not understand the problem for quite some time. Maybe, it's possible to add some concept checking to catch such errors earlier. For example, the attached patch? Thoughs? - Volodya

1 0

program-options thread problem
by Neal D. Becker 27 Apr '04

27 Apr '04

I have both added current program-options to my boost build tree, and all the usual variants of libboost_program_options-gcc.a, also libboost_python-gcc-mt.a. Linking against libboost_program_options-gcc.a I get errors about pthread symbols. Adding -pthread fixes it. It looks to me that libboost_program_options-gcc.a is referencing pthread symbols. nm /usr/local/src/boost_1_31_0.gcc34/stage/lib/libboost_program_options-gcc.a | grep thread U pthread_mutex_destroy U pthread_mutex_init w pthread_mutex_lock w pthread_mutex_unlock w pthread_mutex_lock w pthread_mutex_unlock Yup,sure is.

3 7

Re:Re: [boost] Serialization Formal Review #2
by Robert Ramey 27 Apr '04

27 Apr '04

Matthias Troyer wrote: > I have tried extending the library since I want to swap our old > serialization library used at http://alps.comp-phys.org with a Boost > serialization library as soon as possible. It was important to keep the > same archive format, since we have gigabytes of data collected over ten > years in millions of CPU-hours and need to be able to read those with > both new and old codes. With the help of Robert I managed to convince > myself that this is indeed possible Perhaps it might be possible, but I'm doubtful that it's the best way to address the problem. If the legacy format is a meta-data format it can be possible in a way similar to the way the XML was handled. But in general it will not be desirable nor necessary. To see this take an extreme example. Suppose over the last 10 years we had 10 different programmers working on a the project. Each one had to save and reload data for his classes. Now we want to convert to the new system. We would need a new archive class that tracked all the idiosyncracies in the current code. A huge job. And there exists a much simpler approach. Loading legacy data(legacy_data & ld) ==================== Ifstream is("old_data"); // read first line of old_data file // if it doesn't have the serialization signature // load the data using the legacy system. else{ Boost::binary_iarchive ia(is); ia >> ld } Save data // save in using serialization. As file are processed they are automatically converted to the new system. No special programming is required as the code to load the class instances from the legacy data format already exists - it's the legacy code ! its free at this point. > 4. Documentation of archive formats, especially what class and object > information is stored. I want to be able to predict, from reading the > documentation, what exactly will be written to the archive and in which > order. This would entail a detail paraphrasing of the operation of the code. In the case where there is no versioning, no tracking and no pointer serialization its fairly simple. When any of the others are present, its starts to get pretty complex. There is a comment in basic_archive.cpp which in fact summarizes the format - but I'm not convinced it something that belongs in user documentation. ////////////////////////////////////////////////////////////////////// // // class_information is stored as // // class_id* // -1 for a null pointer // if a new class id // [ // exported key - class name* // tracking level - always/never // file version // ] // // if tracking // [ // object_id // ] // // [ // if a new object id // data... // ] // // * required only for pointers - optional for objects This recursively defines the file format for any serialized data structure. > This is essential when exchanging data with an application that > does not use this library. I'm skeptical that this is going to be fruitful. The "other" application is going to have to effectively re-implement this whole library. Why bother, just use this one. To send data to "other" applications, there is always the XML archive. I don't think that a general purpose tool such as serialization is going to be very helpful in trying to implement some externally defined data format. Some meta-data formats (e.g. XML and windows ini files) are doable but in general it's not going to be productive. Robert Ramey

2 1

Type traits question
by Robert Ramey 26 Apr '04

26 Apr '04

Is there a type traits guru that can explain to me why the following doesn't work as I expect. It's got to be something very, very obvious but I can't see it. Thank you Robert Ramey #include <boost/static_assert.hpp> #include <boost/type_traits/is_base_and_derived.hpp> #include <boost/type_traits/remove_pointer.hpp> class Base1 { char a; }; class Base2 { int b; }; class Derived : public Base1, public Base2 { long c; }; void main(){ // this passes BOOST_STATIC_ASSERT((boost::is_base_and_derived< Base1, Derived >::value)); // this fails !? BOOST_STATIC_ASSERT((boost::is_base_and_derived< boost::remove_pointer<Base1 *>, boost::remove_pointer<Derived *> >::value)); }

3 2

RE: Type traits question
by Robert Ramey 26 Apr '04

26 Apr '04

Never mind, I see it now. Sorry I was desperate. Robert Ramey Robert Ramey wrote: > > #include <boost/static_assert.hpp> > #include <boost/type_traits/is_base_and_derived.hpp> > #include <boost/type_traits/remove_pointer.hpp> > > class Base1 > { > char a; > }; > > class Base2 > { > int b; > }; > > class Derived : public Base1, public Base2 > { > long c; > }; > > void main(){ > // this passes > BOOST_STATIC_ASSERT((boost::is_base_and_derived< > Base1, > Derived > >::value)); > > // this fails !? > BOOST_STATIC_ASSERT((boost::is_base_and_derived< > boost::remove_pointer<Base1 *>, > boost::remove_pointer<Derived *> > >::value)); > }

1 0

Re: [boost] [multi_index] composite keys: request for advice
by JOAQUIN LOPEZ MU?Z 26 Apr '04

26 Apr '04

----- Mensaje original ----- De: Rob Stewart <stewart(a)sig.com> Fecha: Lunes, Abril 26, 2004 10:16 pm Asunto: Re: [boost] [multi_index] composite keys: request for advice > From: Joaquin M Lopez Munoz <joaquin(a)tid.es> > > > > Composite keys can be specified by a new construct > > called composite_key in the following manner: > > > > struct record > > { > > int first; > > int second > > int third; > > }; > > > > multi_index_container< > > record, > > indexed_by< > > composite_key< > > record, //base value > > member<record,int,&record::first>, // first key > > Would that you could make this work to avoid the duplication and > chance for errors: > > member< &record::first > > > I know a function template can deduce the other types, but I > can't think of how to make it work here. > I'd be the happiest man on the block if I could have that, but AFAIK it is not possible. The fact that member<> is here specified in the context of composite_key does not help, either. This has been previously brought into discussion several times. If you have a typeof() utility and don't object to some macro hackery, this is an approximation: template<typename Class,typename Member> Class base_from_ptr_to_member(Member Class::*); template<typename Class,typename Member> Member member_from_ptr_to_member(Member Class::*); #define BOOST_MULTI_INDEX_SMART_MEMBER(PtrToMember) \ member< \ typeof(base_from_ptr_to_member(PtrToMember)),\ typeof(member_from_ptr_to_member(PtrToMember)),\ PtrToMember\ > ... multi_index_container< record, indexed_by< ordered_unique< BOOST_MULTI_INDEX_SMART_MEMBER(&record::x) > > > Joaquín M López Muñoz Telefónica, Investigación y Desarrollo

1 0