- Boost - lists.boost.org

[thread] again ;)
by John Torjo 19 Apr '04

19 Apr '04

Dear boosters, As far as I've heard a while back, the only reason [thread] library cannot be built as a static library was because of TSS. That to me (and to others as I've seen) seems quite a show-stopper - in a lot of apps I don't use the [thread] lib just because of this. Most of my multi-threaded applications (around 95%) and as I know a lot of other multi-threaded apps. don't need TSS. Even if they do, usually they don't need advanced clean-up code (reason for why [thread] was required to be a DLL). ***Most*** of the time, any allocated TSS objects can be let to leak resources (which they hardly have - mostly IMHO some small amount of allocated memory). The above make me think that we really should enable [thread] to be a static library again ;). It should be documented in the docs that the static version of the [thread] runtime will leak TSS objects, and users can choose whether they will use [thread] as a DLL or as a runtime static lib. What do others think? As a side-note, allowing the [thread] lib to be a static lib is quite simple (please you gurus out there, correct me if I'm wrong). In fact, here's the patch. (note: config.hpp = boost/thread/detail/config.hpp, and I did not modify the jamfile.V2, since I can't test it) Best, John // Copyright (C) 2001-2003 // William E. Kempf // // Permission to use, copy, modify, distribute and sell this software // and its documentation for any purpose is hereby granted without fee, // provided that the above copyright notice appear in all copies and // that both that copyright notice and this permission notice appear // in supporting documentation. William E. Kempf makes no representations // about the suitability of this software for any purpose. // It is provided "as is" without express or implied warranty. #ifndef BOOST_THREAD_CONFIG_WEK01032003_HPP #define BOOST_THREAD_CONFIG_WEK01032003_HPP #include <boost/config.hpp> // insist on threading support being available: #include <boost/config/requires_threads.hpp> #if defined(BOOST_HAS_WINTHREADS) # if defined(BOOST_THREAD_BUILD_DLL) # define BOOST_THREAD_DECL __declspec(dllexport) # elif defined(BOOST_DYN_LINK) // john.torjo # define BOOST_THREAD_DECL __declspec(dllimport) # else # define BOOST_THREAD_DECL // linking to library # endif #else # define BOOST_THREAD_DECL #endif // BOOST_HAS_WINTHREADS // john.torjo /* // // Automatically link to the correct build variant where possible. // #if !defined(BOOST_ALL_NO_LIB) && !defined(BOOST_THREAD_NO_LIB) && !defined(BOOST_THREAD_BUILD_DLL) // // Set the name of our library, this will get undef'ed by auto_link.hpp // once it's done with it: // #define BOOST_LIB_NAME boost_thread // // If we're importing code from a dll, then tell auto_link.hpp about it: // # define BOOST_DYN_LINK // // And include the header that does the work: // #include <boost/config/auto_link.hpp> #endif // auto-linking disabled */ #endif // BOOST_THREAD_CONFIG_WEK1032003_HPP # Copyright (C) 2001-2003 # William E. Kempf # # Permission to use, copy, modify, distribute and sell this software # and its documentation for any purpose is hereby granted without fee, # provided that the above copyright notice appear in all copies and # that both that copyright notice and this permission notice appear # in supporting documentation. William E. Kempf makes no representations # about the suitability of this software for any purpose. # It is provided "as is" without express or implied warranty. # # Boost.Threads build Jamfile # # Additional configuration variables used: # 1. PTW32 may be used on Win32 platforms to specify that the pthreads-win32 # library should be used instead of "native" threads. This feature is # mostly used for testing and it's generally recommended you use the # native threading libraries instead. PTW32 should be set to be a list # of two strings, the first specifying the installation path of the # pthreads-win32 library and the second specifying which library # variant to link against (see the pthreads-win32 documentation). # Example: jam -sPTW32="c:\pthreads-win32 pthreadVCE.lib" # Declare the location of this subproject relative to the root. subproject libs/thread/build ; # Include threads.jam for Boost.Threads global build information. # This greatly simplifies the Jam code needed to configure the build # for the various Win32 build types. import ./threads ; { template thread_libs ## sources ## : <template>thread_base ## requirements ## : <sysinclude>$(BOOST_ROOT) ## default build ## : ; # Base names of the source files for libboost_thread. CPP_SOURCES = condition mutex recursive_mutex thread tss xtime once exceptions barrier threadmon ; lib boost_thread : <template>thread_libs ../src/$(CPP_SOURCES).cpp : <runtime-link>static # the common names rule ensures that the library will # be named according to the rules used by the install # and auto-link features: common-variant-tag ; dll boost_thread : <template>thread_libs ../src/$(CPP_SOURCES).cpp : <define>BOOST_THREAD_BUILD_DLL=1 <runtime-link>dynamic # the common names rule ensures that the library will # be named according to the rules used by the install # and auto-link features: common-variant-tag ; stage bin-stage : <dll>boost_thread <lib>boost_thread #: <tag><debug>"d" : debug release ; install thread lib : <dll>boost_thread <lib>boost_thread ; }

3 6

Re: Re: [boost] Re: Using Serialization for binary marshalling
by Robert Ramey 19 Apr '04

19 Apr '04

Jeff Garland wrote: > I believe that Matthew has now demonstrated that archive extension is > possible, which I believe is one of the major changes from the first > review. That said, any documentation of this process would clearly be a > plus. In a typical proprietary archives writing of the version and type > numbers will need to be shut off. So I can imagine documenting these > sorts of issues. As it turns out, type id, and object id are really required only for pointers and version is in fact optional. It would be possible to make an archive which: a) trapped (BOOST_STATIC_ASSERT) attempts to serialize a pointer b) trapped attempt to save/load object id and class id c) implemented null serialization of version numbers and trapped attempts to use version number != 0 This would work only on serializations that had implementation attributes of no versioning, and no object tracking. If used on other types, it would trap at compiler time. I believe that you would have what you wanted. In general, the part of the library which saves/loads the preamble is invoked only for pointers. An easy way to check this is to generate XML archive and find that there are not attributes for this types. Robert Ramey

2 1

a note on serialization docs
by David Abrahams 19 Apr '04

19 Apr '04

When viewing http://www.rrsd.com/boost/libs/serialization/doc/index.html in IE6, the right ends of some of the words are tucked underneath the scrollbar at the right of the window. The HTML or stylesheet should have some kind of margin to prevent this effect. Cheers, Dave -- Dave Abrahams Boost Consulting http://www.boost-consulting.com

1 1

Re:Re: [boost] Re: Using Serialization for binary marshalling
by Robert Ramey 19 Apr '04

19 Apr '04

> Jeff Garland writes: > Yes, for 'random access' archives (think relational database buffer here) > it's possible the archive process will need additional meta-data not > provided in the base library setup (think mapping of classes to tables and > attributes to columns). And yes, I've implemented this one before as well > -- it's a very handy bit of infrastructure. > but in fact I believe given the current library it could now > be done by writing and archive and perhaps some enhancements to the > registration. I faced the same problem with XML meta-data. I resolved with the NVP wrapper which kept XML out of the library core - really a big thing for me as I have had to continually refactor to keep things from growing totally out of control. I'm sure this idea of making a wrapper which includes meta-data along with the data itself is going to be useful in cases like this. > I think in the past Robert has considered this "out of scope", Well, yes. I have fought a continuing battle to limit scope. > BTW, I think the references should include a reference to this paper which > discusses many of these variations and design issues. > http://www.ubilab.org/publications/print_versions/pdf/plop-96-serializer.pdf I've seen this paper, and at this suggestion was made before. I think I included a reference to it but the link moved. There's another whole field to plow regarding web references as opposed to published ones. Robert Ramey

1 0

move semantics
by Andrea Torsello 19 Apr '04

19 Apr '04

Hi, I have been investigating move semantics and think that I came up with a solution that is strongly influenced by both David Abrahams' move approach and Andrei Alexandrescu's mojo, but solves some of the problems I have encountered with them. The basic idea is to use the explicit keyword to force the compiler to use the X(X const &) constructor only in two cases. 1) When explicitly copying a const object i.e. X const x; X y(x); //use explicit copy constructor 2) When passing by const ref void f(X const &); X makeX(); void foo() { f(makeX()); //use explicit copy constructor } In all other cases the other constructor take precedence. Note that the template trick David Abrahams uses in his move approach would lead to an error on a conforming compiler when confronted with case #2 (unless more recent versions corrected this). I chose to keep the temporary and constant subtypes from mojo because they allow me to discriminate between const values, non-const rvalues and non-const rvalues. The lack of this capability was the major problem I had with David Abrahams' move. My use-case was a vector-like container that increases but never decreases the size of its backing store. In order to provide the never decreasing backing-store semantic, operator = moves the backing store from a temporary only if the new data does not fit in the existing space. Hence, operator = must be able to discriminate between temporaries and non-temporaries. My solution fullfills almost all the requirements I had: 1) passing by value moves non-const rvalues and copies everithing else. 2) its is transparent to the user of the class. Alexandrescu's Mojo fails this because of the special return type, while Abrahams' move fails it because of the pass-by-const-ref problem described above. 3) it allows to discriminate between constants, non-const lvalues, and non-const rvalues. Alexandrescu's Mojo allows it, while Abrahams' move does not. 4) Provides move semantics to templated classes with (almost) no odd side-effect. The only side-effect is that template type deduction does not work with temporary discrimination. Hence in the sample code the template type of the "discriminate" function must be specified explicitly. please find attached a sample file illustrating my move approach. I tested the code with gcc 3.3.1 and successfully compiled it with comeau online. What do you think? Andrea Torsello P.S. please cc me as I am not subscribed and I check the mailinglist archives sporadically begin 666 move_test.cc M(VEN8VQU9&4\:6]S=')E86T^#0H-"@T*=7-I;F<@<W1D.CIC;W5T.PT*=7-I M;F<@<W1D.CIE;F1L.PT*#0IN86UE<W!A8V4@;6]V90T*>PT*"71E;7!L871E M(#QC;&%S<R!4/B!S=')U8W0@96YA8FQE9 T*"7L-"@D)8VQA<W,@8V]N<W1A M;G0@+R\@='EP92!S=6=A<B!F;W(@8V]N<W1A;G1S#0H)"7L-"@D)8V]N<W0@ M5"H@9&%T85\[#0H)"7!U8FQI8SH-"@D)97AP;&EC:70@8V]N<W1A;G0H8V]N M<W0@5"8@;V)J*2 Z(&1A=&%?*"9O8FHI('M]#0H)"6-O;G-T(%0F(&=E="@I M(&-O;G-T('L@<F5T=7)N("ID871A7SL@?0T*"0E].PT*#0H)"6-L87-S('1E M;7!O<F%R>2 Z('!R:79A=&4@8V]N<W1A;G0@+R\@='EP92!S=6=A<B!F;W(@ M=&5M<&]R87)I97,-"@D)>PT*"0EP=6)L:6,Z#0H)"65X<&QI8VET('1E;7!O M<F%R>2A4)B!O8FHI(#H@8V]N<W1A;G0H;V)J*2![?0T*"0E4)B!G970H*2!C M;VYS="![(')E='5R;B!C;VYS=%]C87-T/%0F/BAC;VYS=&%N=#HZ9V5T*"DI M.R!]#0H)"7T[#0H-"@EO<&5R871O<B!T96UP;W)A<GDH*0T*"7L-"@D@(" @ M<F5T=7)N('1E;7!O<F%R>2AS=&%T:6-?8V%S=#Q4)CXH*G1H:7,I*3L-"@E] M#0H);W!E<F%T;W(@8V]N<W1A;G0H*2!C;VYS= T*"7L-"@D@(" @<F5T=7)N M(&-O;G-T86YT*'-T871I8U]C87-T/&-O;G-T(%0F/B@J=&AI<RDI.PT*"7T- M"@T*#0H)<')O=&5C=&5D.@T*"0EE;F%B;&5D*"D@>WT@+R\@:6YT96YD960@ M=&\@8F4@9&5R:79E9"!F<F]M#0H)"7YE;F%B;&5D*"D@>WT@+R\@:6YT96YD M960@=&\@8F4@9&5R:79E9"!F<F]M#0H)?3L-"GT-"@T*=&5M<&QA=&4\='EP M96YA;64@5#X-"F-L87-S(%D@.B!P=6)L:6,@;6]V93HZ96YA8FQE9#Q9/%0^ M(#X-"GL-"G!U8FQI8SH-"G1Y<&5D968@='EP96YA;64@;6]V93HZ96YA8FQE M9#Q9/%0^(#XZ.G1E;7!O<F%R>2!T96UP;W)A<GD[#0IT>7!E9&5F('1Y<&5N M86UE(&UO=F4Z.F5N86)L960\63Q4/B ^.CIC;VYS=&%N="!C;VYS=&%N=#L- M"@T*62@I('M]#0H-"F5X<&QI8VET(%DH63Q4/B!C;VYS=" F*2![(&-O=70@ M/#P@(F5X<&QI8VET(&-O<'D@8V]N<W1R=6-T;W)<;B([('T-"EDH63Q4/B8I M('L@8V]U=" \/" B;F]N+6-O;G-T(&QV86QU92!C;W!Y(&-O;G1R=6-T;W)< M;B([('T-"EDH8V]N<W1A;G0I('L@8V]U=" \/" B8V]N<W0@8V]P>2!C;VYS M=')U8W1O<EQN(CL@?0T*62AT96UP;W)A<GDI('L@8V]U=#P\(")N;VXM8V]N M<W0@<G9A;'5E(&UO=F4@8V]N<W1R=6-T;W)<;B([('T-"GT[#0H-"@T*=&5M M<&QA=&4\='EP96YA;64@5#X-"ED\5#X@;6%K95DH*2![<F5T=7)N(%D\5#XH M*3M]#0H-"G1E;7!L871E/'1Y<&5N86UE(%0^#0I9/%0^(&-O;G-T(&UA:V59 M8V]N<W0H*2![<F5T=7)N(%D\5#XH*3M]#0H-"@T*=&5M<&QA=&4\='EP96YA M;64@5#X-"G9O:60@9V5T62A9/%0^*2![?0T*#0IT96UP;&%T93QT>7!E;F%M M92!4/@T*=F]I9"!G9719<F5F*%D\5#XF*2![?0T*#0IT96UP;&%T93QT>7!E M;F%M92!4/@T*=F]I9"!G97198V]N<W1?<F5F*%D\5#X@8V]N<W0@)BD@>WT- M"@T*#0IT96UP;&%T93QT>7!E;F%M92!4/@T*=F]I9"!D:7-C<FEM:6YA=&4H M63Q4/B8I('MC;W5T(#P\(")D:7-C<FEM:6YA=&4Z(&YO;BUC;VYS="!L=F%L M=65<;B([?0T*#0IT96UP;&%T93QT>7!E;F%M92!4/@T*=F]I9"!D:7-C<FEM M:6YA=&4H='EP96YA;64@63Q4/CHZ8V]N<W1A;G0I('MC;W5T(#P\(")D:7-C M<FEM:6YA=&4Z(&-O;G-T('9A;'5E7&XB.WT-"@T*=&5M<&QA=&4\='EP96YA M;64@5#X-"G9O:60@9&ES8W)I;6EN871E*'1Y<&5N86UE(%D\5#XZ.G1E;7!O M<F%R>2D@>V-O=70@/#P@(F1I<V-R:6UI;F%T93H@;F]N+6-O;G-T(')V86QU M95QN(CM]#0H-"FEN="!M86EN*"D-"GL-"ED\:6YT/B!Y,3L-"ED\:6YT/B!C M;VYS="!Y,CL-"@T*63QI;G0^('0Q*'DQ*3L@+R]C;W!Y(&YO;BUC;VYS="!L M=F%L=64-"ED\:6YT/B!T,BAY,BD[("\O8V]P>2!C;VYS="!L=F%L=64-"ED\ M:6YT/B!T,RAM86ME63QI;G0^*"DI.R O+V-O<'D@=&5M<&]R87)Y#0I9/&EN M=#X@=#0H;6%K95EC;VYS=#QI;G0^*"DI.R O+V-O<'D@8V]N<W0@=&5M<&]R M87)Y#0H-"F=E=%EC;VYS=%]R968H>3$I.R O+W!A<W,M8GDM8V]N<W0M<F5F M(&YO;BUC;VYS="!L=F%L=64-"F=E=%EC;VYS=%]R968H>3(I.R O+W!A<W,M M8GDM8V]N<W0M<F5F(&-O;G-T(&QV86QU90T*9V5T66-O;G-T7W)E9BAM86ME M63QI;G0^*"DI.R O+W!A<W,M8GDM8V]N<W0M<F5F(&YO;BUC;VYS="!T96UP M;W)A<GD-"F=E=%EC;VYS=%]R968H;6%K95EC;VYS=#QI;G0^*"DI.R\O<&%S M<RUB>2UC;VYS="UR968@8V]N<W0@=&5M<&]R87)Y#0H-"F=E=%DH>3$I.R O M+W!A<W,M8GDM=F%L=64@;F]N+6-O;G-T(&QV86QU90T*9V5T62AY,BD[("\O M<&%S<RUB>2UV86QU92!C;VYS="!L=F%L=64-"F=E=%DH;6%K95D\:6YT/B@I M*3L@+R]P87-S+6)Y+79A;'5E(&YO;BUC;VYS="!T96UP;W)A<GD-"F=E=%DH M;6%K95EC;VYS=#QI;G0^*"DI.R O+W!A<W,M8GDM=F%L=64@;F]N+6-O;G-T M('1E;7!O<F%R>0T*#0ID:7-C<FEM:6YA=&4\:6YT/BAY,2D[("\O;F]N+6-O M;G-T(&QV86QU90T*9&ES8W)I;6EN871E/&EN=#XH>3(I.R O+V-O;G-T(&QV M86QU90T*9&ES8W)I;6EN871E/&EN=#XH;6%K95D\:6YT/B@I*3L@+R]N;VXM M8V]N<W0@=&5M<&]R87)Y#0ID:7-C<FEM:6YA=&4\:6YT/BAM86ME66-O;G-T M/&EN=#XH*2D[("\O8V]N<W0@=&5M<&]R87)Y#0H-"@T*<F5T=7)N(# [#0I] ` end

5 38

Re: Re: [boost] Re: Using Serialization for binary marshalling
by Robert Ramey 19 Apr '04

19 Apr '04

Jeff Garland wrote: >> Robert Ramey wrote: >> So I'm skeptical of trying to adjust to "old" proprietary formats >> with the serialization library. > Well, I believe you are taking too narrow a view here. OK, I'll expand my horizon a bit. I can see how one might want to make special purpose archive which only handles a subset of all possible C++ structures. So it really comes down to evaluating the specific situation. There is nothing in the serialization library which conflicts with such usage so I'm happy to remain agnostic ( though still perhaps wary ) on this case. I wonder what happens when we need "special" information in the archive. I faced the same problem with XML where we need the name of the instance variable. I solved it by making the NVP wrapper which has worked well. However it does introduce a coupling between the archive and the serialization which I had strived to avoid. The best I could do was to make it optional and transparent to those archives which didn't use it. In order to do this I had to make all archive classes aware of it. Well, for XML this might be justified but in general I would find it objectionable. When one makes the archive dependent upon the serialization (E.G. by addressing only a subset of all C++), he won't be able to run the torture test suite. Personally, I consider this a significant liability. So anyway, if it works for a specific problem, then of course I've got no concerns. If its proposed as addition to the library, I would like to see it be universal as the current ones are - if only for the reason that a new archive can be subjected to the torture test with very little effort. So to summarize, if one wants/needs to make special purpose archive which handles a subset of all types - no problem. But it probably would not be of interest outside of the particular application. Robert Ramey

1 0

Re: [boost] Re: Serialization compile errors on CW9
by Robert Ramey 19 Apr '04

19 Apr '04

Message: 1 Date: Sun, 18 Apr 2004 13:54:08 -0400 From: Miro Jurisic <macdev(a)meeroh.org> Subject: To: Message-ID: <macdev-C68DBE.13540818042004(a)sea.gmane.org> In article <20040418160047.656883147E(a)acme.west.net>, "Robert Ramey" <ramey(a)rrsd.com> wrote: > Miro Jurisic wrote: > namespace detail { > #if BOOST_WORKAROUND... > typedef ::mbstate_t mbstate_t; > #else > typedef std::mbstate_t mbstate_t; > #endif > } OK - thanks, done, Robert Ramey

1 0

Named params library and BGL
by Vladimir Prus 19 Apr '04

19 Apr '04

I've just made an attempt to use the named parameters library (currently in review queue, and available at http://groups.yahoo.com/group/boost/files/named_params.zip) to simply properties in BGL. Currently, to initialize all properties one has to do: edge_descriptor e = add_edge(....); put(e, g, vertex_color, 10); put(e, g, vertex_name, "foo"); I hope that with the named parameters library it will be possible to do: add_edge(v1, v2, (vertex_color = 10, vertex_name = "foo"), g); I've tried to implement this idea, but run into the problems. First issue is documentation: it gives foo_impl(foo_keywords(a0)); as example, while the code uses: return f_impl(f_keywords()(t, name_)); Which has extra '()' after f_keywords. The second problem is that I need to create a type for 'keywords' (derived from 'keywords<...>' and use it for passing arguments). The docs suggest to create a number of forwarding functions, but given that a number of vertex properties can be rather large (and is actually unbounded), this does not seem good. So, now can do: vertex_property p = prop_keywords()(color = 10, name = "foo"); but I'd rather like: vertex_property p((color = 10, name = "foo")); So, the operator, will be overloaded to create something I can index with 'tag type' and get a value. In fact, this will allow to avoid declaring 'pop_keywords' -- since again, user can declare it's own keywords so it's not clear how to define that class. The example I've played with is at: http://zigzag.cs.msu.su:7813/p.cpp Comments are appreciated. - Volodya

4 9

RE: Boost Digest, Vol 700, Issue 1
by S G Ganesh 19 Apr '04

19 Apr '04

I am an engineer in HP's aCC compiler team. We are actively working on Boost defects and the internal developmental version of the compiler compiles many of the Boost libraries successfully. There is a compiler patch (for both PA and IPF) coming up by end of this month: if any of you are interested and have a support contract, you can register for beta testing. The current compiler status for aCC shows that the pass percentage is dismal 26%, but with this patch, it should be more than 70% (we are working on improving it further). Many libraries, such as regex, bind, any, thread already compile successfully with this patch compiler. Please note that the fixes are in the compiler without modifying the Boost sources; we came across a few defects in the Boost sources which we can share with you so that they can be fixed (or provide a workaround or #ifdefed). It would be great if we can work together to resolve any issues, which will be mutually beneficial. If you come across any defects in the compiler while compiling the Boost sources, you can file bug reports for the same. Any issues on developing with aC++ compiler will be immediately responded in cxx-dev(a)cup.hp.com newsgroup. -Ganesh S G Ganesh HP PA C++ Compiler Front-end Team Phone: +91-80-2205 1832 ------------------------------ Message: 15 Date: Sat, 17 Apr 2004 11:54:11 +0100 From: "John Maddock" <john(a)johnmaddock.co.uk> Subject: Re: [boost] boost on HP-UX 11i To: <boost(a)lists.boost.org> Message-ID: <06af01c4246a$58c62350$cbfc0352@fuji> Content-Type: text/plain; charset="iso-8859-1" > I recently downloaded boost libraries to use the smart_ptr libraries. It > appears to be working. But several other libraries, as shown by the > compiler report is not. I also noticed that last run date is 9 months > ago. Is anybody working on getting boost to work on aCC? I would be very > surprised if nobody has tried before since HP is a top-tier vendor, but > I couldn't find any useful information from the archives. If not, I > would like to take a stab at getting it to work. I have contact with HP > aCC techs to fix problems if it is a compiler problem. I'm particularly > interested in getting the libraries regex and spirit (for now, more > later) to work. I did a search on the boost archive and the last > reference to this subject was written back in August 14, 2003: I'd love to see regex working with aCC if it's humanly possible, if you want to mail me privately with any queries you may have that would be fine - especially if you have a working relationship with HP personnel - we've managed to persuade quite a few other vendors to work with us, and even to use Boost for their internal regression tests, HP is one of the notable exceptions so far :-| John.

2 1

serialization: review
by Thorsten Ottosen 19 Apr '04

19 Apr '04

Hi Robert, Here is my review of your library. a.. What is your evaluation of the design? Seems fine. I have a few issues though. Why isn't there a base class for all archieves? I think that would be useful with class hierachies...for example, I need to implement two function and cannot use & anymore. Consider this struct mammal : boost::noncopyable { private: friend class boost::serialization::access; virtual void do_serialize( boost::archive::text_oarchive& ar, unsigned version ) = 0; virtual void do_serialize( boost::archive::text_iarchive& ar, unsigned version ) = 0; template< class Archive > void serialize( Archive & ar, unsigned version ) { do_serialize( ar, version ); } public: virtual const std::string& name() const = 0; virtual unsigned age() const = 0; virtual ~mammal() {} }; Some way of supporting only one do_serialize() to preserve the order would be nice. a.. What is your evaluation of the implementation? There are some minor compiler problems and suggestions listed below. I can't figure out exactly how the library save/loads pointers when these cannot be allocated on the stack. a.. What is your evaluation of the documentation? I already gave some feedback on the introduction. In general it seems ok. I like the comparison with other lbraries. I miss more specific type requirements. For example, is it necessary to have a default constructor? Is it necessary to be stack-allocable? must the destructor be public? a.. What is your evaluation of the potential usefulness of the library? It's certainly useful. a.. Did you try to use the library? With what compiler? Did you have any problems? yes, see below. I can compile my code with vc71, gcc3.3 comeau 4.3.3. a.. How much effort did you put into your evaluation? A glance? A quick reading? In-depth study? 5 hours. It's neither a glance nor an in-depth study. I did try to extend the library to use my new smart containers; I was almost sucessful. a.. Are you knowledgeable about the problem domain? hm...no. a.. Do you think the library should be accepted as a Boost library? Be sure to say this explicitly so that your other comments don't obscure your overall opinion yes. But I think the pointer part of the library need to be given extra thought; I would like to see the focus shift from vector<T*> towards vector< shared_ptr<T> > and ptr_vector<T>. using T* array[sz] or vector<T*> is inherently unsafe if the pointers are heap-allocated. I tried to extend the library to support my smart containers, but I coulnd't figure out what I did wrong. I think I might have saved them correctly, but I cannot figure out to load them. However, I do think that is a problem that can be solved together with Robert. (Robert, you can find the ptr_vector in the sandbox. If you could cast a glance on the code and tell me how the body of load_collection should look like, it would be great.) freestanding libraries: Obvious candidates are (a) BOOST_STRONG_TYPEDEF (could maybe be part of utility) (b) dataflow_iterators best regards Thorsten ---------- Some general nitpicks/comments (with these comments my test works on vc71, como4.3.3, g++3.3.1: 1. have you planned to use concept checks 2. documentation: can the width of the html be made adaptive to the window width? The right window must be scrolled to see it's contents which is annoying. 3. const members uses a const-cast to re-init them. AFAICT, this is undefined behavior (cmp 7.1.5.1). I guess the need for serialization is just another reason for not having const members. 4. AFAICR, the use of placement new require proper alignment, so the object must eg. be heap-allocated. Is that guaranteed? 5. I think the exception code should be returned by a function: exception_code code() const; this is how eg. the regex_error exception in tr1 will do it. 6. remove trailing comma in archive_exception.hpp: "unregistered_cast // base - derived relationship not registered with" 7. archive/detail/basic_oarchive.hpp includes itself 8. is_abstract.hpp: there is something wierd about the is_abstact struct. I uncommented the first part to be able to compile. 9. serialization/serialization.hpp: why all the static casts? template<class Archive, class T> inline void serialize( Archive & ar, T & t, const BOOST_PFTO unsigned int file_version ){ access::serialize(ar, t, static_cast<const unsigned int>(file_version)); } AFAICT, they should be removed. Comeau has the follwing warning: type qualifier is meaningless on cast type 10. nvp.hpp: line 50: ar & t.value(); There is on t-parameter. 11. /archive/detail/oserializer.hpp", line 244: NULL reference is not allowed return * static_cast<const basic_pointer_oserializer *>(NULL); ^ This not yet legal C++ (but the committee is changing that) use a static member and return that instead. Also, why all the static_casts? 12. two-phase lookup problems: /boost/archive/basic_text_oarchive.hpp", line 65: error #20: identifier "This" is undefined archive::save(* This(), t); ^ Solution: prefix base class functions with this->. remark: why is this->This()->XX() necessary? this->xx() should do it. 13: archive/text_oarchive.hpp, similar lookup problems. this->newtoken(), this->delimiter = this->none; 14: /archive/detail/basic_iarchive.hpp", line 46: error #20: identifier "basic_iarchive_impl" is undefined boost::scoped_ptr<basic_iarchive_impl> pimpl; ^ solution: remember to forward declare basic_iarchieve_impl. Do the same for basic_oarchieve_impl. 15: /archive/detail/archive_pointer_iserializer.hpp", line 42: error #284: (+detail/iserializer.hpp", line 240:) NULL reference is not allowed return *static_cast<const basic_iserializer *>(NULL); ^ Solution: use a static member again. 16: two-phase lookup problems in archive/basic_text_iarchive.hpp", Solution: prefix by this->. 17. when you save_collection_impl.hpp (eg in vector.hpp) there is no need to specify template arguments again since they will be deduced. 18. implementation of save_collection(). you cannot use unsigned int count portably. Instead you should use the new collection traits (reviewed after this review) as follows: typename boost::size_type_of< Collection >::type count = size( s ); then the code will also work for iterator views and arrays. Similar comments apply to load_collection_impl.hpp 19. missing #include <boost/serialization/nvp.hpp> in serialization.hpp begin 666 smart_container.cpp M(VEN8VQU9&4@/&9S=')E86T^#0HC:6YC;'5D92 \<W1R:6YG/@T*(VEN8VQU M9&4@/&EO<W1R96%M/@T*(VEN8VQU9&4@/&)O;W-T+V%R8VAI=F4O=&5X=%]O M87)C:&EV92YH<' ^#0HC:6YC;'5D92 \8F]O<W0O87)C:&EV92]T97AT7VEA M<F-H:79E+FAP<#X-"B-I;F-L=61E(#QB;V]S="]S97)I86QI>F%T:6]N+W-T M<FEN9RYH<' ^#0HC:6YC;'5D92 \8F]O<W0O<V5R:6%L:7IA=&EO;B]V97)S M:6]N+FAP<#X-"B-I;F-L=61E(#QB;V]S="]S97)I86QI>F%T:6]N+W-P;&ET M7VUE;6)E<BYH<' ^#0HC:6YC;'5D92 \8F]O<W0O<V5R:6%L:7IA=&EO;B]V M96-T;W(N:'!P/@T*(VEN8VQU9&4@/&)O;W-T+W-E<FEA;&EZ871I;VXO97AP M;W)T+FAP<#X-"B-I;F-L=61E(#QB;V]S="]P=')?8V]N=&%I;F5R+W!T<E]V M96-T;W(N:'!P/@T*(VEN8VQU9&4@/&)O;W-T+V%S<VEG;B]S=&PN:'!P/@T* M(VEN8VQU9&4@/&)O;W-T+VYO;F-O<'EA8FQE+FAP<#X-"@T*+R\O+R\O+R\O M+R\O+R\O+R\O+R\O+R\O+R\O+PT*+R\@<'1R('9E8W1O<B!S97)I86QI>F%T M:6]N#0H-"B-I;F-L=61E(#QB;V]S="]S97)I86QI>F%T:6]N+V-O;&QE8W1I M;VYS7W-A=F5?:6UP+FAP<#X-"B-I;F-L=61E(#QB;V]S="]S97)I86QI>F%T M:6]N+V-O;&QE8W1I;VYS7VQO861?:6UP+FAP<#X-"B-I;F-L=61E(#QB;V]S M="]S97)I86QI>F%T:6]N+W-P;&ET7V9R964N:'!P/@T*#0IT96UP;&%T93QC M;&%S<R!!<F-H:79E+"!C;&%S<R!5+"!C;&%S<R!!;&QO8V%T;W(^#0II;FQI M;F4@=F]I9"!S879E* T*(" @($%R8VAI=F4@)B!A<BP-"B @("!C;VYS="!B M;V]S=#HZ<'1R7W9E8W1O<CQ5+"!!;&QO8V%T;W(^("9T+ T*(" @('5N<VEG M;F5D(&EN="!F:6QE7W9E<G-I;VX-"BD-"GL-"B @("!B;V]S=#HZ<V5R:6%L M:7IA=&EO;CHZ<W1L.CIS879E7V-O;&QE8W1I;VXH(&%R+"!T("D[#0I]#0H- M"G1E;7!L871E/&-L87-S($%R8VAI=F4L(&-L87-S(%4L(&-L87-S($%L;&]C M871O<CX-"FEN;&EN92!V;VED(&QO860H#0H@(" @07)C:&EV92 F(&%R+ T* M(" @(&)O;W-T.CIP=')?=F5C=&]R/%4L($%L;&]C871O<CX@)G0L#0H@(" @ M=6YS:6=N960@:6YT(&9I;&5?=F5R<VEO;@T**0T*>PT*+RH@,2X@8V]M<&EL M97,L(&)U="!C<F%S:&5S#0H@(" @(" @('-T;#HZ;&]A9%]C;VQL96-T:6]N M/ T*(" @(" @("!!<F-H:79E+ T*(" @(" @("!B;V]S=#HZ<'1R7W9E8W1O M<CQ5+"!!;&QO8V%T;W(^+ T*(" @(" @("!S=&PZ.F%R8VAI=F5?:6YP=71? M<V5Q/$%R8VAI=F4L(&)O;W-T.CIP=')?=F5C=&]R/%4L($%L;&]C871O<CX@ M/BP-"B @(" @(" @<W1L.CIR97-E<G9E7VEM<#QB;V]S=#HZ<'1R7W9E8W1O M<CQ5+"!!;&QO8V%T;W(^(#X-"B @(" ^*&%R+"!T*3L-"B @(" J+PT*?0T* M#0HO+R!S<&QI="!N;VXM:6YT<G5S:79E('-E<FEA;&EZ871I;VX@9G5N8W1I M;VX@;65M8F5R(&EN=&\@<V5P87)A=&4-"B\O(&YO;B!I;G1R=7-I=F4@<V%V M92]L;V%D(&UE;6)E<B!F=6YC=&EO;G,-"G1E;7!L871E/&-L87-S($%R8VAI M=F4L(&-L87-S(%4L(&-L87-S($%L;&]C871O<CX-"FEN;&EN92!V;VED('-E M<FEA;&EZ92@-"B @("!!<F-H:79E("8@87(L#0H@(" @8F]O<W0Z.G!T<E]V M96-T;W(\52P@06QL;V-A=&]R/B F('0L#0H@(" @8V]N<W0@=6YS:6=N960@ M:6YT(&9I;&5?=F5R<VEO;@T**7L-"B @("!S<&QI=%]F<F5E*&%R+"!T+"!F M:6QE7W9E<G-I;VXI.PT*?0T*#0H-"B\O+R\O+R\O+R\O+R\O+R\O+PT*+R\@ M8VQA<W,@:&EE<F%C:'D-"@T*<W1R=6-T(&UA;6UA;" Z(&)O;W-T.CIN;VYC M;W!Y86)L90T*>PT*<')I=F%T93H-"B @(" -"B @("!F<FEE;F0@8VQA<W,@ M8F]O<W0Z.G-E<FEA;&EZ871I;VXZ.F%C8V5S<SL-"B @("!V:7)T=6%L('9O M:60@9&]?<V5R:6%L:7IE*"!B;V]S=#HZ87)C:&EV93HZ=&5X=%]O87)C:&EV M928@87(L('5N<VEG;F5D('9E<G-I;VX@*2 ](# [#0H@(" @=FER='5A;"!V M;VED(&1O7W-E<FEA;&EZ92@@8F]O<W0Z.F%R8VAI=F4Z.G1E>'1?:6%R8VAI M=F4F(&%R+"!U;G-I9VYE9"!V97)S:6]N("D@/2 P.PT*(" @( T*(" @('1E M;7!L871E/"!C;&%S<R!!<F-H:79E(#X-"B @("!V;VED('-E<FEA;&EZ92@@ M07)C:&EV92 F(&%R+"!U;G-I9VYE9"!V97)S:6]N("D-"B @("![#0H@(" @ M(" @(&1O7W-E<FEA;&EZ92@@87(L('9E<G-I;VX@*3L-"B @("!]#0H@(" @ M#0IP=6)L:6,Z#0H-"B @("!V:7)T=6%L(&-O;G-T('-T9#HZ<W1R:6YG)B!N M86UE*"D@8V]N<W0@/2 P.PT*(" @('9I<G1U86P@=6YS:6=N960@(" @(" @ M(" @(&%G92@I(&-O;G-T(" ](# [#0H@(" @(" @(" @#0H@(" @=FER='5A M;"!^;6%M;6%L*"D@>WT-"GT[#0H-"G-T9#HZ;W-T<F5A;28@;W!E<F%T;W(\ M/"@@<W1D.CIO<W1R96%M)B!O<RP@8V]N<W0@;6%M;6%L)B!M("D-"GL-"B @ M("!R971U<FX@;W,@/#P@(FYA;64@/2 B(#P\(&TN;F%M92@I(#P\("(@86=E M(#T@(B \/"!M+F%G92(a)I.R -"GT-"@T*<W1R=6-T(&%P92 Z('!U8FQI8R!M M86UM86P-"GL-"B @("!A<&4H*3L-"B @("!A<&4H(&-O;G-T('-T9#HZ<W1R M:6YG)B!N86UE+"!U;G-I9VYE9"!A9V4@*3L-"B @("!V:7)T=6%L(&-O;G-T M('-T9#HZ<W1R:6YG)B!N86UE*"D@8V]N<W0[#0H@(" @=FER='5A;"!U;G-I M9VYE9" @(" @(" @(" @86=E*"D@8V]N<W0[#0IP<FEV871E.@T*(" @('9I M<G1U86P@=F]I9"!D;U]S97)I86QI>F4H(&)O;W-T.CIA<F-H:79E.CIT97AT M7V]A<F-H:79E)B!A<BP@=6YS:6=N960@=F5R<VEO;B I.PT*(" @('9I<G1U M86P@=F]I9"!D;U]S97)I86QI>F4H(&)O;W-T.CIA<F-H:79E.CIT97AT7VEA M<F-H:79E)B!A<BP@=6YS:6=N960@=F5R<VEO;B I.PT*(" @( T*(" @('-T M9#HZ<W1R:6YG(" @;F%M95\[#0H@(" @=6YS:6=N960@(" @("!A9V5?.PT* M?3L-"@T*<W1R=6-T('=H86QE(#H@<'5B;&EC(&UA;6UA; T*>PT*(" @('=H M86QE*"D[#0H@(" @=VAA;&4H(&-O;G-T('-T9#HZ<W1R:6YG)B!N86UE+"!U M;G-I9VYE9"!A9V4@*3L-"B @("!V:7)T=6%L(&-O;G-T('-T9#HZ<W1R:6YG M)B!N86UE*"D@8V]N<W0[#0H@(" @=FER='5A;"!U;G-I9VYE9" @(" @(" @ M(" @86=E*"D@8V]N<W0[#0IP<FEV871E.@T*(" @('9I<G1U86P@=F]I9"!D M;U]S97)I86QI>F4H(&)O;W-T.CIA<F-H:79E.CIT97AT7V]A<F-H:79E)B!A M<BP@=6YS:6=N960@=F5R<VEO;B I.PT*(" @('9I<G1U86P@=F]I9"!D;U]S M97)I86QI>F4H(&)O;W-T.CIA<F-H:79E.CIT97AT7VEA<F-H:79E)B!A<BP@ M=6YS:6=N960@=F5R<VEO;B I.PT*(" @( T*(" @('-T9#HZ<W1R:6YG(" @ M;F%M95\[#0H@(" @=6YS:6=N960@(" @("!A9V5?.PT*?3L-"@T*0D]/4U1? M0TQ!4U-?15A03U)47T=5240H(&%P92P@(F%P92(@*0T*0D]/4U1?0TQ!4U-? M15A03U)47T=5240H('=H86QE+" B=VAA;&4B("D-"@T*+R\O+R\O+R\O+R\O M+R\O+R\-"B\O(&]R9&5R:6YG<PT*#0IS=')U8W0@:6Y?;F%M95]O<F1E<@T* M>PT*(" @(&)O;VP@;W!E<F%T;W(H*2@@8V]N<W0@;6%M;6%L)B!L+"!C;VYS M="!M86UM86PF('(@*0T*(" @('L-"B @(" @(" @<F5T=7)N(&PN;F%M92@I M(#P@<BYN86UE*"D[#0H@(" @?0T*?3L-"@T*+R\O+R\O+R\O+R\O+R\O+R\- M"B\O('1E<W0-"@T*:6YT(&UA:6XH*0T*>PT*(" @('1R>0T*(" @('L-"@T* M(" @(" @("!U<VEN9R!N86UE<W!A8V4@8F]O<W0Z.F%S<VEG;FUE;G0[#0H@ M(" @(" @( T*(" @(" @("!B;V]S=#HZ<'1R7W9E8W1O<CQM86UM86P^('9E M8SL-"B @(" @(" @+R\@87-S:6=N('!O<W-I8FEL:71Y.B!O;F4@;75S="!B M92!A8FQE('1O('-P96-I9GD@=&AE('1Y<&4@=&\@8V]N<W1R=6-T#0H@(" @ M(" @("\O(&5G#0H@(" @(" @("\O('!T<E]A<W-I9VX\87!E/B@@=F5C("DH M(E@B+"!Y("D[(&%S<VEG;CQA<&4^*"!V96,@*2 ](&YE=R!!<&4H(")8(BP@ M>2 I.R -"B @(" @(" @+R\@<'1R7V%S<VEG;CQW:&%L93XH('9E8R I*")8 M(BP@>2 I.R -"B @(" @(" @=F5C("L](&YE=R!A<&4H(")&<F%N:R(L(#$R M("DL(&YE=R!A<&4H(")"971T>2(L(#D@*2P@;F5W('=H86QE*" B2F]N87,B M+" S," I+"!N97<@=VAA;&4H(")'97)D82(L(#(T("D[#0H@(" @(" @("\O M=F5C+G-O<G0H(&EN7VYA;65?;W)D97(H*2 I.PT*(" @(" @(" -"B @(" @ M(" @<W1D.CIO9G-T<F5A;2!O9G,H(")M86UM86QS+F1A="(@*3L-"B @(" @ M(" @8F]O<W0Z.F%R8VAI=F4Z.G1E>'1?;V%R8VAI=F4@;W5T7W1E>'0H(&]F M<R I.PT*(" @(" @("!O=71?=&5X=" \/"!V96,[#0H@(" @(" @(&]F<RYC M;&]S92(a)I.PT*(" @(" @("!S=&0Z.FEF<W1R96%M(&EF<R@@(FUA;6UA;',N M9&%T(B I.PT*(" @(" @("!B;V]S=#HZ87)C:&EV93HZ=&5X=%]I87)C:&EV M92!I;E]T97AT*"!I9G,@*3L-"B @(" @(" @8F]O<W0Z.G!T<E]V96-T;W(\ M;6%M;6%L/B!C;W!Y.PT*(" @(" @("!I;E]T97AT(#X^(&-O<'D[#0H@(" @ M(" @( T*(" @(" @("!F;W(H('-I>F5?="!I(#T@,#L@:2 \('9E8RYS:7IE M*"D[("LK:2 I#0H@(" @(" @(" @("!S=&0Z.F-O=70@/#P@=F5C6VE=(#P\ M(&-O<'E;:5T@/#P@)UQN)SL-"B @("!]#0H@(" @8V%T8V@H('-T9#HZ97AC M97!T:6]N)B!E("D-"B @("![#0H@(" @(" @('-T9#HZ8V]U=" \/"!E+G=H M870H*3L@#0H@(" @?0T*?0T*#0HO+R\O+R\O+R\O+R\O+R\O+R\O+R\O#0HO M+R!I;7!L96UE;G1A=&EO;B!A<&4-"@T*87!E.CIA<&4H*0T*>PT*?0T*#0IA M<&4Z.F%P92@@8V]N<W0@<W1D.CIS=')I;F<F(&YA;64L('5N<VEG;F5D(&%G M92 I(#H@;F%M95\H(&YA;64@*2P@86=E7R@@86=E("D-"GL-"GT-"B @(" - M"F-O;G-T('-T9#HZ<W1R:6YG)B!A<&4Z.FYA;64H*2!C;VYS= T*>PT*(" @ M(')E='5R;B!N86UE7SL-"GT-"B @(" -"G5N<VEG;F5D(&%P93HZ86=E*"D@ M8V]N<W0-"GL-"B @("!R971U<FX@86=E7SL-"GT-"B @(" -"G9O:60@87!E M.CID;U]S97)I86QI>F4H(&)O;W-T.CIA<F-H:79E.CIT97AT7V]A<F-H:79E M)B!A<BP@=6YS:6=N960@=F5R<VEO;B I#0I[#0H@(" @87(@/#P@;F%M95\@ M/#P@86=E7SL-"GT-"@T*=F]I9"!A<&4Z.F1O7W-E<FEA;&EZ92@@8F]O<W0Z M.F%R8VAI=F4Z.G1E>'1?:6%R8VAI=F4F(&%R+"!U;G-I9VYE9"!V97)S:6]N M("D-"GL-"B @("!A<B ^/B!N86UE7R ^/B!A9V5?.PT*?0T*#0HO+R\O+R\O M+R\O+R\O+R\O+R\O+R\O+R\O#0HO+R!I;7!L96UE;G1A=&EO;B!W:&%L90T* M#0IW:&%L93HZ=VAA;&4H*0T*>PT*?0T*#0IW:&%L93HZ=VAA;&4H(&-O;G-T M('-T9#HZ<W1R:6YG)B!N86UE+"!U;G-I9VYE9"!A9V4@*2 Z(&YA;65?*"!N M86UE("DL(&%G95\H(&%G92 I#0I[#0I]#0H@(" @#0IC;VYS="!S=&0Z.G-T M<FEN9R8(a)=VAA;&4Z.FYA;64H*2!C;VYS= T*>PT*(" @(')E='5R;B!N86UE M7SL-"GT-"B @(" -"G5N<VEG;F5D('=H86QE.CIA9V4H*2!C;VYS= T*>PT* M(" @(')E='5R;B!A9V5?.PT*?0T*(" @( T*=F]I9"!W:&%L93HZ9&]?<V5R M:6%L:7IE*"!B;V]S=#HZ87)C:&EV93HZ=&5X=%]O87)C:&EV928@87(L('5N M<VEG;F5D('9E<G-I;VX@*0T*>PT*(" @(&%R(#P\(&%G95\@/#P@;F%M95\[ M#0I]#0H-"G9O:60@=VAA;&4Z.F1O7W-E<FEA;&EZ92@@8F]O<W0Z.F%R8VAI M=F4Z.G1E>'1?:6%R8VAI=F4F(&%R+"!U;G-I9VYE9"!V97)S:6]N("D-"GL- A"B @("!A<B ^/B!A9V5?(#X^(&YA;65?.R -"GT-"@T* ` end

1 0