Re: [Boost-bugs] [Boost C++ Libraries] #6780: [BGL] add Maximum Adjacency Search

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #6780: [BGL] add Maximum Adjacency Search
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2012-08-21 17:45:11

#6780: [BGL] add Maximum Adjacency Search
-------------------------------+--------------------------------------------
  Reporter:  fvilas@…          |       Owner:  jewillco                    
      Type:  Patches           |      Status:  new                         
 Milestone:  To Be Determined  |   Component:  graph                       
   Version:  Boost 1.48.0      |    Severity:  Problem                     
Resolution:                    |    Keywords:  BGL Maximum Adjacency Search
-------------------------------+--------------------------------------------

Comment (by jewillco):

 Here are my comments:

 * What is the reason for having `mas_visitor_event_not_overridden` rather
 than just using `void` for the default return value?

 * Where does `unsigned long` come from in the return type of
 `maximum_adjacency_search`?  Should there be some type obtained from a
 traits class used there instead?

 * Please have a version of any named-parameter function in the namespace
 `boost::graph` that uses Boost.Parameter, then have the old-style named
 parameter version just forward to it (look at
 `<boost/graph/isomorphism.hpp>` for a simple example).

 * Please try to avoid using Boost.Typeof (including the `BOOST_AUTO`
 macro) since some compilers that can otherwise compile Boost.Graph have
 trouble with it.

 * What is the reason for copying the priority queue on entry to
 `stoer_wagner_min_cut` rather than passing in a reference like before?

 Other than these issues, I think it's basically ready to put in, and it
 should make it into 1.52.  Thank you for your contribution, and sorry for
 the delayed responses.

-- 
Ticket URL: <https://svn.boost.org/trac/boost/ticket/6780#comment:6>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.