Re: [Boost-bugs] [Boost C++ Libraries] #13457: Windows port for 1.66.0 incorrectly includes NTVERP.H

Subject: Re: [Boost-bugs] [Boost C++ Libraries] #13457: Windows port for 1.66.0 incorrectly includes NTVERP.H
From: Boost C++ Libraries (noreply_at_[hidden])
Date: 2018-05-03 01:45:09

#13457: Windows port for 1.66.0 incorrectly includes NTVERP.H
--------------------------------------+-----------------------------
  Reporter:  Brian Catlin <BrianC@…>  |      Owner:  Andrey Semashev
      Type:  Bugs                     |     Status:  closed
 Milestone:  To Be Determined         |  Component:  winapi
   Version:  Boost 1.66.0             |   Severity:  Showstopper
Resolution:  invalid                  |   Keywords:  windows
--------------------------------------+-----------------------------

Comment (by Brian Catlin <BrianC@…>):

 It is common to share a Version.h header file between resource (.rc) files
 and source files (.cpp), to give the program access to the version
 information placed in the executable's version info section. Moving the
 definitions of the version macros before the header includes solves
 nothing; the macros are still re-defined because you're including
 NTVERP.H. Why not check to see if the macros are already defined before
 including NTVERP.H?

-- 
Ticket URL: <https://svn.boost.org/trac10/ticket/13457#comment:3>
Boost C++ Libraries <http://www.boost.org/>
Boost provides free peer-reviewed portable C++ source libraries.